Scheduler: delete Appointment enhancements#32633
Open
sjbur wants to merge 24 commits intoDevExpress:26_1from
Open
Scheduler: delete Appointment enhancements#32633sjbur wants to merge 24 commits intoDevExpress:26_1from
sjbur wants to merge 24 commits intoDevExpress:26_1from
Conversation
Tucchhaa
reviewed
Feb 20, 2026
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/scheduler.ts
Outdated
Show resolved
Hide resolved
Tucchhaa
reviewed
Feb 20, 2026
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/scheduler.ts
Outdated
Show resolved
Hide resolved
Tucchhaa
reviewed
Feb 20, 2026
packages/devextreme/js/__internal/scheduler/__tests__/appointment_tooltip.test.ts
Show resolved
Hide resolved
Tucchhaa
reviewed
Feb 20, 2026
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/scheduler.ts
Show resolved
Hide resolved
Tucchhaa
reviewed
Feb 20, 2026
packages/devextreme/js/__internal/scheduler/__tests__/collector_tooltip.test.ts
Outdated
Show resolved
Hide resolved
aleksei-semikozov
previously approved these changes
Feb 20, 2026
Tucchhaa
reviewed
Feb 20, 2026
| tooltipScrollableContent?.dispatchEvent(new FocusEvent('focusin', { bubbles: true })); | ||
| tooltipScrollableContent?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Delete', bubbles: true })); | ||
|
|
||
| expect(POM.tooltip.isVisible()).toBe(true); |
Contributor
There was a problem hiding this comment.
can we check that appointment is not deleted from dataSource instead of checking that tooltip is visible? I thought we have a task, to try not hide tooltip on appt delete. So, it would be less problems for us in the future if we remove this visibility check
Contributor
There was a problem hiding this comment.
Moreover the test doesn't actually check that appointment wasn't deleted...
Tucchhaa
reviewed
Feb 20, 2026
| tooltipScrollableContent?.dispatchEvent(new FocusEvent('focusin', { bubbles: true })); | ||
| tooltipScrollableContent?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Delete', bubbles: true })); | ||
|
|
||
| expect(POM.tooltip.isVisible()).toBe(true); |
Contributor
There was a problem hiding this comment.
Can we check datasource data instead of tooltip visibility here too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.