feat: Allow proxy settings to be overridden.#189
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the SDK’s request customization surface to support overriding proxy configuration via IRestOptions, and wires those new options into the shared OkHttp client setup.
Changes:
- Added proxy-related getters to
IRestOptions(proxy, proxy selector, proxy authenticator). - Updated
APIUtils.applyRestOptionsto apply the new proxy settings to the OkHttp builder. - Updated
DevCycleLocalClientTest’sIRestOptionsanonymous implementation to satisfy the expanded interface (plus minor formatting/import cleanup).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/main/java/com/devcycle/sdk/server/common/api/IRestOptions.java |
Adds new proxy customization methods to the public REST options interface. |
src/main/java/com/devcycle/sdk/server/common/api/APIUtils.java |
Applies proxy configuration from IRestOptions onto the OkHttp client builder. |
src/test/java/com/devcycle/sdk/server/local/DevCycleLocalClientTest.java |
Updates test IRestOptions implementation to include new proxy-related methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/devcycle/sdk/server/common/api/IRestOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/devcycle/sdk/server/common/api/IRestOptions.java
Outdated
Show resolved
Hide resolved
kaushalkapasi
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow network level proxy settings to be overridden.