Conversation
JamieSinn
reviewed
Sep 29, 2026
Comment on lines
+61
to
+69
| // the API appends new keys, so reverse to put the most recent first | ||
| const keysNewestFirst = [...activeKeys].reverse() | ||
| if (keysNewestFirst.every(({ key }) => !key)) { | ||
| throw new Error( | ||
| `Your credentials do not have permission to view ${sdkType} SDK keys for environment ` + | ||
| `${environmentKey}. Publisher permissions are required for protected environments.`, | ||
| ) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
why are we reversing the order here? if we're inverting the API response would that not confuse people on which is accurate? We don't have a createdat timestamp anywhere.
Contributor
Author
There was a problem hiding this comment.
This is still an open question, since the dashboard is being updated to show the latest token on the landing page with the details being shown in another view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-allto match the selector option(compromised)local run showing the following for an old compromised key and the newly created one.