Expand-Archive has no flag "-DestinationPath", changed to "-OutputPath"#198
Open
map588 wants to merge 2 commits intoDeusData:mainfrom
Open
Expand-Archive has no flag "-DestinationPath", changed to "-OutputPath"#198map588 wants to merge 2 commits intoDeusData:mainfrom
map588 wants to merge 2 commits intoDeusData:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the Windows installer’s archive extraction step by updating the parameter used when calling Expand-Archive.
Changes:
- Update
Expand-Archiveinvocation to use-OutputPathinstead of-DestinationPath.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Copilot suggested checking whether the flag was supported on the users version of powershell @DeusData It was not compatible with mine until I modified that flag but apparently it was supported in PS 5.1. |
DeusData
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows install script fails because the Expand-Archive command uses a flag which does not exist.
This commit changes "DestinationPath" to the correct argument "-OutputPath".