test: verify sanitizer build configuration - #1716
Draft
astandrik wants to merge 2 commits into
Draft
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Signed-off-by: astandrik <astandrik@yandex-team.ru>
Signed-off-by: astandrik <astandrik@yandex-team.ru>
astandrik
force-pushed
the
codex/fix-1648-sanitized-build-config
branch
from
August 18, 2026 18:49
4619986 to
ba0c499
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1648 by checking what each test runner was actually compiled with.
test-runner --build-configexits before suite or test-cache setup and prints one exact line:sanitized=<0|1> test_seams=<0|1>.scripts/test.shchecks that line immediately after building the runner in its iteration, full, and TSan paths.scripts/msan.shperforms the same check before its suites start. If a stale or misconfigured runner disagrees with the lane, the script now stops before any suite can run with the wrong timing budget.The patch only changes
tests/test_main.c,scripts/test.sh, andscripts/msan.sh. It does not touch the Makefile, workflows, dependencies, or production code.Checks run
sanitized=0 test_seams=1sanitized=1 test_seams=1SANITIZEpathsscripts/test.shon Linux x86-64bash -n scripts/test.sh scripts/msan.shgit diff HEAD^ HEAD --checkApple Silicon ASan and TSan fail in the sanitizer runtime before
main, so they do not provide evidence about this patch. The remote MSan path is also blocked before its build command because the Compose service is pinned tolinux/arm64and the x86-64 builder has no binfmt/QEMU registration. Windows CLANG64/CLANGARM64 and the authoritative sanitizer lanes remain for CI.Full lint reaches existing diagnostics in unchanged source files; none of the three files in this patch appears in that output.
Checklist
git commit -s): CI requires DCO.make -f Makefile.cbm test): the full Linux run passed remotely, while the Apple sanitizer runtime blocks the local default.make -f Makefile.cbm lint-ci): the current baseline reports diagnostics in unchanged source files.