fix(registry): drop unique_name CALLS across language boundaries - #1702
fix(registry): drop unique_name CALLS across language boundaries#1702rudi193-cmd wants to merge 1 commit into
Conversation
DeusData#1647 dropped suffix_match only. unique_name (candidates==1) still bound Python `from unittest.mock import patch` to a unique TSX `patch`. Same language-family guard; JS/TS/TSX stay one family. Fixes DeusData#1572 Signed-off-by: rudi193-cmd <rudi193@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
CI red on this PR is not the #1572 change. Every failing shard dies on the same two tests, both predating this branch:
Windows shard 2/2 also has an unrelated UTF-8 compare (
|
|
Thank you for keeping this to the remaining |
What does this PR do?
Follow-on to #1647 / #725. That PR dropped
suffix_matchCALLS when caller language ≠ target file language and leftunique_name(candidates == 1) for this issue.Python
from unittest.mock import patchwas binding to a unique TSXfunction patchviaunique_name. The same helper now dropsunique_nameunder the same rules: JS/TS/TSX stay one family;same_module/import_map/lsp_*stay.Not in this PR: treating
unittest.mockas an external specifier, IMPORTS-edge cleanup, #1555 receiver disambiguation, or #1128.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
scripts/test.sh --suites registry,pipeline)make -f Makefile.cbm lint-ci)Fixes #1572
Made with Cursor