Restrict bulk update target finding group to authorized groups#15356
Open
svader0 wants to merge 1 commit into
Open
Restrict bulk update target finding group to authorized groups#15356svader0 wants to merge 1 commit into
svader0 wants to merge 1 commit into
Conversation
The bulk finding update view looked up the target finding group without any authorization check, while the submitted findings were already scoped to the user's authorized products. Scope the group lookup the same way and add a regression test covering the cross-product case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scopes the target finding group in the bulk finding update to the groups the user is authorized to edit, matching the authorization already applied to the submitted findings. Adds a regression test. No functional change for correctly-permissioned users.
Keeps object permission checks consistent across the operation.