Skip to content

fix: pass username strings instead of Dojo_User objects to create_not… #14927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donhluca wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

fix: pass username strings instead of Dojo_User objects to create_not… #14927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dojo/notifications/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@ def process_tag_notifications(request, note, parent_url, parent_title):
usernames_to_check = set(un.lower() for un in regex.findall(note.entry)) # noqa: C401

users_to_notify = [
Dojo_User.objects.filter(username=username).get()
username
for username in usernames_to_check
if Dojo_User.objects.filter(is_active=True, username=username).exists()
]
Expand Down
Loading