Fix SARIF parser crash on empty extensions#14898
Open
kleomartiny wants to merge 2 commits into
Open
Conversation
Handle empty or missing tool.extensions in SARIF parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14897
This PR fixes a SARIF parser crash when importing valid SARIF 2.1.0 reports with empty
results, emptydriver.rules, and missing or emptytool.extensions.Previously the parser assumed that
extensions[0]always exists whendriver.rulesis empty:rules_array = run["tool"]["extensions"][0].get("rules", [])This could lead to:
IndexError: list index out of rangeThe fix safely iterates through available extensions and collects rules only if they are present, avoiding unsafe indexing and correctly handling spec-compliant SARIF files with no findings.
Tested with the minimal SARIF sample attached in issue #14897.