Handle "None" target group in help and targets listing#33
Open
paulius-krutkis-dcd wants to merge 1 commit into
Open
Handle "None" target group in help and targets listing#33paulius-krutkis-dcd wants to merge 1 commit into
paulius-krutkis-dcd wants to merge 1 commit into
Conversation
The SDK reports a literal "None" group for a couple of targets (universal_ecommerce, youtube_video), which surfaced as "None scrape target" in help and a "None:" heading in `decodo targets`. Add resolveTargetGroup, which treats a missing or "None" group as no group. Subcommand help now falls back to "Scrape target" and the targets listing folds them into "Other" — no per-target special casing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few SDK targets (
universal_ecommerce,youtube_video) report a literal"None"group. That leaked into the UI asNone scrape targetin--helpand aNone:heading indecodo targets.Adds
resolveTargetGroup, which treats a missing or"None"group as no group:Scrape target(wasNone scrape target).decodo targets→ those targets fold intoOther(was aNone:heading).Data-driven on the group value — no per-target name checks. Independent of the batch/timeout PRs; branches off
main.