-
Notifications
You must be signed in to change notification settings - Fork 0
perf(core): cut ORM/REST serialization overhead for entity template and graph endpoints #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmornati
wants to merge
1
commit into
main
Choose a base branch
from
perf-p1-cut-orm-serialization-overhead
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
src/main/java/com/decathlon/idp_core/domain/model/entity/EntityIdentity.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package com.decathlon.idp_core.domain.model.entity; | ||
|
|
||
| import java.util.UUID; | ||
|
|
||
| /// Lightweight projection carrying only the identifying fields of an | ||
| /// [Entity] — `id`, `templateIdentifier`, `identifier`, `name` — without its | ||
| /// properties or relations. | ||
| /// | ||
| /// **Business purpose:** Some callers only need to resolve which entity a | ||
| /// business key (`templateIdentifier` + `identifier`) refers to, including | ||
| /// its technical UUID, without paying the cost of hydrating and mapping the | ||
| /// full property/relation graph. The primary consumer is graph traversal | ||
| /// (`EntityGraphService#getEntityGraph`), which resolves the root entity's | ||
| /// identity here and then loads its relationship graph via a dedicated batch | ||
| /// query — the properties/relations on the root [Entity] would otherwise be | ||
| /// discarded, so fetching them was pure overhead (perf #131). | ||
| public record EntityIdentity(UUID id, String templateIdentifier, String identifier, String name) { | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
...athlon/idp_core/infrastructure/adapters/persistence/configuration/CacheConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package com.decathlon.idp_core.infrastructure.adapters.persistence.configuration; | ||
|
|
||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import org.springframework.cache.CacheManager; | ||
| import org.springframework.cache.annotation.EnableCaching; | ||
| import org.springframework.cache.caffeine.CaffeineCacheManager; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| import com.decathlon.idp_core.domain.service.entity_template.EntityTemplateService; | ||
| import com.github.benmanes.caffeine.cache.Caffeine; | ||
|
|
||
| /// Cache configuration backing read-mostly domain lookups that would | ||
| /// otherwise hit the database on every call. | ||
| /// | ||
| /// **Business purpose:** `EntityTemplate` definitions are read on nearly every | ||
| /// entity read/write request (property type resolution, relation target | ||
| /// template resolution) but change infrequently (admin-driven CRUD). Caching | ||
| /// them removes a redundant DB round trip from every entity operation without | ||
| /// affecting correctness, since template mutations explicitly evict their | ||
| /// cache entry (see [EntityTemplateService]). | ||
| /// | ||
| /// **Why Caffeine:** high-performance, near-optimal caching library with a | ||
| /// simple size/time-bound eviction policy — avoids unbounded memory growth | ||
| /// while keeping hot templates resident. | ||
| @Configuration | ||
| @EnableCaching | ||
| public class CacheConfiguration { | ||
|
|
||
| @Bean | ||
| public CacheManager cacheManager() { | ||
| CaffeineCacheManager cacheManager = new CaffeineCacheManager( | ||
| EntityTemplateService.ENTITY_TEMPLATES_CACHE); | ||
| cacheManager.setCaffeine(Caffeine.newBuilder().maximumSize(500) | ||
| .expireAfterWrite(10, TimeUnit.MINUTES).recordStats()); | ||
| return cacheManager; | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have an EntitySummary Record wit this information. There is just the technical id missing.