Repository navigation
Add integrated research poster projects - #23
Conversation
|
Thanks, this is a useful foundation. Anton has directly authorized me to refine this poster integration proactively, so I am preparing a maintainer follow-up on this PR rather than asking you to iterate a rejection list. I am adding actual generated-poster Docker/PDF checks, a fresh compiler image identity for the changed package warmup, scalable poster fonts and retained license text in exported sources, plus PDF measurement/UI regression coverage. No candidate code is being executed on DGX; verification remains on hosted CI before the normal protected exact-head squash. |
DebelToni
left a comment
There was a problem hiding this comment.
Reviewed all 24 changed-file patches at 6a64053 against current main 64913d0, with complete patch counts and exact full-blob identity verification. No remaining blocking findings.
Under Anton's direct proactive authorization I added a maintainer commit on top of Slavov88's foundation: scalable poster fonts, a new compiler-image identity for the changed package warmup, license retention in generated/exported source, whitespace-safe TeX metadata, unambiguous custom dimensions, and PDF status placement/measurement regressions. No contributor tests, builds, installers or scripts ran on DGX before acceptance.
Hosted CI run 42834831725 passed the full checks and real restricted-Docker regression. All three poster themes were compiled at A1 landscape, A0 portrait and 1000 x 700 mm custom dimensions. Each PDF was parsed with the already-shipped PDF.js parser and verified as one page with matching physical dimensions and visible title/author text; no font-shape substitution or overfull box warning. Legacy worker replacement, init/reaping, private nested source and SyncTeX/cache regression assertions remain. Viewer tests verify print dimensions independent of zoom, multipage warnings, failed-replacement preservation and clearing when PDF data disappears.
Reviewed template option bounds/TeX escaping, normal account/project permission flow, filename-aware compile path, raster edge/area cap without altering downloaded PDF bytes, responsive setup controls and MIT provenance. No migrations, authentication/permission changes, dependency lock changes, review/workflow changes or installed host-automation changes. Exact-head test/analyze and CodeQL successful with protections unchanged. This establishes hosted output correctness, not physical print quality or a Safari device test; production deployment remains gated on this merge's exact-main push CI.
What this adds
Verification
afterEachwhile local disks were nearly full; this run is not a full passing suite.Reviewer note
If you would change a design detail or see an improvement, please accept this foundation once the required checks and review criteria are satisfied, then make the refinement yourself in a follow-up. Please call out any blocker that must be fixed before merge.