Skip to content

Make online collaborators visible on tap and click - #20

Merged
DebelToni merged 1 commit into
mainfrom
feat/online-collaborators
Oct 31, 2026
Merged

DebelToni merged 1 commit into
mainfrom
feat/online-collaborators

Conversation

@DebelToni

Copy link
Copy Markdown
Owner

Scope

  • Only the workspace presence UI, its styles, and regression tests.
  • Desktop avatars and the online count now open a full named list on click or keyboard activation.
  • Narrow screens expose a compact people/count button with a 44px touch target instead of hiding presence.
  • The list uses existing live presence data, wraps long names, includes overflow avatars, and handles empty state. No presence protocol, permissions, sharing, or deployment changes.

Verification

  • pnpm check: passed (142 web tests, 157 server tests; normal Docker-only skip in default suite).
  • pnpm test:compiler: passed with real Docker.
  • Local Node 26 requires NODE_OPTIONS="--max-old-space-size=8192 --no-experimental-webstorage" for jsdom tests; no project workaround added.
  • Playwright Chromium against the built app with mocked HTTP/WebSocket peers: passed at 320, 390, 768, 900, 901, 1024, and 1440px. Checked tap/click/Enter opening, full names including matching initials, long-name wrapping, live departure updates, Escape/close dismissal, desktop focus restoration, and presence/Compile non-overlap.
  • Browser script and screenshots: /home/xaj/tmp/overroot-presence-browser.mjs and /home/xaj/tmp/overroot-presence-chromium-*.png.
  • WebKit execution was blocked by missing host dependencies; no Safari test result claimed.

Awaiting the existing owner review/CI flow; no direct deployment or merge attempted.

@DebelToni DebelToni left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete three-file diff at 8a9af31 against current main 665ee47. No blocking findings.

The existing presence data now opens a named list through a native button and the existing Modal component. Reviewed overflow/matching initials, full escaped names, live join/leave updates, empty state, project-keyed state isolation, responsive visibility and 44px narrow-screen target. Regression tests cover opening/closing, all names beyond four avatars, live departures/arrivals and empty states. No extra presence requests, protocol/permission changes, dependency/workflow changes or host automation.

Exact-head hosted test/analyze and CodeQL passed. No contributor code, tests, installers or builds were executed by this reviewer on DGX. Author-provided narrow/desktop screenshots were inspected; browser interaction tests were not independently repeated, and no Safari/device result is claimed.

@DebelToni
DebelToni merged commit c510cd5 into main Oct 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant