Client parity follow-ups (re-target to main): unify client, TODOs, tests, CI, versions#87
Merged
Merged
Conversation
- fix(vscode #75): escape nested template literals in endpointTesterPanel so the webview HTML literal no longer desyncs the parser; build @flapi/shared automatically (shared prepare + extension prebuild) so EndpointConfig types resolve. Extension builds and typechecks again (broken since 2025-11-02). - feat(cli #76): add commands for server capabilities that had no CLI surface: health, config env, config filesystem, endpoints parameters, cache audit [path], cache gc. - fix(cli #77): FlapiApiClient.testEndpoint targets the real /template/test route instead of the non-existent /test (would 404). - docs: add CLIENT_PARITY_AUDIT.md documenting findings and resolution.
#81, #83, #85) - refactor(vscode #83): delete the extension's duplicate FlapiApiClient and point extension.ts + yamlValidator at @flapi/shared's client; add slug-based validateEndpointConfig/reloadEndpointConfig and X-Config-Token to setToken. Fixes the local client's broken base-URL (it read non-existent flapi.host/port). - fix(vscode #81): remove dead 'Variables provider' editor-change handler. - chore(#85): align cli, @flapi/shared, and the extension to 26.6.13.
…79, #80) - feat(#80): add a pure extendedYaml resolver that inlines {{include:<section> from <file>}} directives from sibling workspace files; CodeLens now uses it instead of stripping includes and parsing blindly. - feat(#79): when multiple endpoints reference one SQL template, show a QuickPick selector instead of silently using the first.
) - test(vscode #84): set up Vitest and cover the pure logic — extended-YAML include resolution and endpoint-pick label building (12 tests). - ci(#82): add .github/workflows/clients.yaml that builds @flapi/shared, builds and tests the CLI, and typechecks/builds/tests the extension on every PR that touches cli/. This would have caught #75.
Keeps package-lock.json in step with the version bump so 'npm ci' (used by the new clients CI gate) doesn't fail on a version mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the follow-up work from #86 onto
main. #86 was merged into thefix/client-parity-auditbranch, but #78 had already squash-merged tomainjust before, so these changes never reachedmainand issues #79–#85 stayed open. The net diff here is exactly the follow-up changes.Closes #79
Closes #80
Closes #81
Closes #82
Closes #83
Closes #84
Closes #85
Contents
@flapi/shared's API client (Unify VSCode extension on the shared @flapi/shared API client #83) and remove the dead Variables handler (Remove dead 'Variables provider' code in VSCode extension #81).{{include}}directives client-side for CodeLens parsing (CodeLens: resolve extended-YAML {{include}} directives for accurate parsing #80).clients.yamlCI gate building/typechecking/testing cli + shared + extension (Add CI compile/build gate for cli, shared, and vscode-extension #82).26.6.13and sync lockfiles (Align flapii CLI / shared / extension versions with server scheme #85).Verification
@flapi/sharedbuilds; CLI builds + 41/41 tests; extensiontsc --noEmit0 errors + webpack build + 12/12 tests;npm ciworks in all three packages.