Fix null customer first names in silver transformation - #15
Open
drop2vsk wants to merge 1 commit into
Open
Conversation
drop2vsk
marked this pull request as draft
August 25, 2026 15:05
drop2vsk
marked this pull request as ready for review
August 25, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While validating the Bronze-to-Silver transformation for crm_cust_info, I noticed a data-quality issue where a record with cst_key = A01Ass has a NULL value for cst_firstname.
During row-count validation, I observed:
silver.erp_loc_a101: 18,484 rows
silver.crm_cust_info: 18,485 rows
Further investigation identified the above record with a NULL cst_firstname.
Changes Made
I added a condition to the transformation to prevent records with a NULL cst_firstname from being loaded into the Silver layer:
AND cst_firstname IS NOT NULL
Validation
I verified the affected record and checked the transformation logic after applying the change.
Expected Result
Records with a NULL cst_firstname will no longer be loaded into silver.crm_cust_info.
I would appreciate a review of this change and any feedback regarding the proposed transformation logic.