feat: Add Adaptive Kafka watermark generator#346
Open
ferenc-csaky wants to merge 1 commit into
Open
Conversation
ferenc-csaky
force-pushed
the
feat/adaptive-watermark-gen
branch
from
f5dd621 to
0c3a726
Compare
ferenc-csaky
commented
Jun 1, 2026
Comment on lines
+35
to
+40
| static final int MIN_RECORDS = 250; | ||
| static final int SAMPLE_SIZE = 4096; | ||
| static final long MIN_OUT_OF_ORDERNESS_MILLIS = 50L; | ||
| static final long MAX_OUT_OF_ORDERNESS_MILLIS = Duration.ofDays(1).toMillis(); | ||
|
|
||
| private static final double OUT_OF_ORDERNESS_QUANTILE = 0.95D; |
Collaborator
Author
There was a problem hiding this comment.
Possibly we can make these (or some) configurable, and have the current hardcoded values as defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SOURCE_WATERMARK()support tokafka-safeandupsert-kafka-safe.Changes
Implemented
KafkaRecordTimestampWatermarkStrategy.Updated
SafeKafkaDynamicSource.SupportsSourceWatermark.SOURCE_WATERMARK()is requested.WatermarkStrategy.noWatermarks()otherwise.Added
KafkaSourceWatermarkIT.Updated Redpanda test setup.
Validation
mvn -pl connectors/kafka-safe-connector -Dtest=KafkaRecordTimestampWatermarkStrategyTest test mvn -pl flink-sql-runner -am -Dtest=NoSuchTest -Dit.test=KafkaSourceWatermarkIT verify