refactor(lineage): fold whole-model-impact into the CLL experience#1421
Open
danyelf wants to merge 2 commits into
Open
refactor(lineage): fold whole-model-impact into the CLL experience#1421danyelf wants to merge 2 commits into
danyelf wants to merge 2 commits into
Conversation
Remove the separate `whole_model_impact` server flag and gate the whole-model impact surfaces (NodeView title chip + left stripe, LineageNode graph badge, change-category text-label suppression, whole-model impact set computation) on `new_cll_experience` instead. Whole-model impact was always a subset of the CLL experience, so the two now travel together: CLL on -> both render; CLL off -> neither. Drops the `--whole-model-impact` CLI option and its implied-flag wiring; the frontend `wholeModelImpact` identifier is removed in favor of `newCllExperience`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Danyel Fisher <danyel@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Now that computeImpactedSets always returns the whole-model sets, tighten ImpactSets to require them and drop the unreachable EMPTY_SET fallbacks in publish (the sole producer always supplies both). EMPTY_SET remains the stable initial-state reference. Update the hook tests accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Danyel Fisher <danyel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
refactorWhat this PR does / why we need it:
--whole-model-impactwas a separate server flag whose only way to be enabledalso forced
--new-cll-experienceon. In practice whole-model impact is asubset of the CLL experience — there's never a reason to have one without the
other. This PR removes the standalone flag and gates the whole-model-impact
surfaces on
new_cll_experienceinstead, so the two always travel together:Backend
--whole-model-impactClick option, itsflagdict entry, and theimplied-flag block in
recce/cli.py.Frontend (full merge — the
wholeModelImpactidentifier is gone, not aliased)RecceServerFlagsno longer carrieswhole_model_impact.wholeModelImpactfield (the computedwholeModelChangedNodeIds/wholeModelImpactedNodeIdsdata sets stay).computeImpactedSetsalways computes the whole-model sets — it's only evercalled when
newCllExperience && cll.change-category text-label suppression now gate on
newCllExperience— whichevery one of those sites already had in scope, so it's a direct substitution.
Which issue(s) this PR fixes:
Special notes for your reviewer:
--new-cll-experience: they nowget the whole-model surfaces automatically (previously gated behind the extra
flag).
recce/data/(embedded frontend bundle) is not included here — it's agenerated artifact regenerated by the normal build/release step.
--new-cll-experience:/api/flagreturnsnew_cll_experience: truewith nowhole_model_impactkey; the graph rendersADD/COLUMNbadges, suppressesthe category text labels, and NodeView shows the amber whole-model-impacted
title chip + stripe on a downstream-impacted model.
pnpm type:check/pnpm lint/pnpm run buildclean; full frontendsuite 3979 passed;
pytest tests/test_cli.py23 passed;black/isort/flake8clean.
Does this PR introduce a user-facing change?: