Surface SUM and AVG on booleans as an error#1952
Merged
shangyian merged 3 commits intoDataJunction:mainfrom Apr 3, 2026
Merged
Surface SUM and AVG on booleans as an error#1952shangyian merged 3 commits intoDataJunction:mainfrom
SUM and AVG on booleans as an error#1952shangyian merged 3 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
shangyian
changed the title
SUM on booleans as an error
shangyian
changed the title
SUM on booleans as an errorSUM and AVG on booleans as an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
SUM(bool_type)andAVG(bool_type)in DJ should surface an error. Removing theBooleanTypehandler means that.infer_type(BooleanType)will now fall through and raise aTypeError/NotImplementedError, which gets caught during node compilation as a validation error.Users will see a type mismatch and know to use
CAST(expr AS BIGINT)orSUM(CASE WHEN expr THEN 1 ELSE 0 END)explicitly.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan