Typed GraphQL Service Layer#1672
Draft
shangyian wants to merge 3343 commits intoDataJunction:mainfrom
Draft
Conversation
* Bumping DJ to version 0.0.1a99 * Fix lint --------- Co-authored-by: GitHub Actions Bot <>
* Switch Dialect enum to strings in database * Rebase * Add docs for custom transpilation plugins * Add test coverage and cleanup
* Speed up the recursive dimensions graph CTE query * Fix * Add node paths * Consistency * Cleanup and get to parity * Fix additional tests * Fix linters * Fix reference link with roles * Fix linters * Fix lint * Fix lint
Co-authored-by: GitHub Actions Bot <>
…on#1390) * Add graphql schema generation script and seed with generated schema * Include schema.graphql in packaging
* Add /cubes endpoint to get metadata on all cubes * Change query param to catalog
…tion#1388) * Fix the derived expression of count distinct metrics to use the count distinct argument * Add separate treatment of measures for distinct quantifier aggregations * Add support to complex expressions inside distinct-agg metrics * Refactor names and add tests for resolving metric components * Cleanup * More naming cleanup * Add graphql naming refactor * Update comments and update GraphQL schema
* Add pagination to /cubes endpoint * don't pull inactive nodes for /cubes/... endpoints
* Add endpoint to list available dialects * Add support for GraphQL querying of dialects
Co-authored-by: GitHub Actions Bot <>
* Fix an issue where renaming dimensions for measures SQL creates should include both columns * Fix tests * Refactor to make it cleaner
…1396) * Add option to delete materializations by node version. * Lint and commments addressed. * Comment addressed plus added node_revision_id to Materialization output.
* Replaces use of Depends(get_session) in get_context() with session middleware, since the former doesn't support teardown in Strawberry. * Add test for db session middleware * Fix tests
…ataJunction#1402) * When a node is deactivated, its materializations should be as well * Fix tests
Co-authored-by: GitHub Actions Bot <>
* Add filtering on columns for node revisions in GQL * Add tests for resolvers
* Add docker compose with superset * Remove comments * add password init * Add secret key * docker compose file that works with superset * Fix * Fix names * Fix --------- Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: GitHub Actions Bot <>
Fix the ignore files for unit test workflow.
* Fix test action. * Add UI code filter.
shangyian
force-pushed
the
api-ui-mocks
branch
from
1d2f8e4 to
b5d8652
Compare
shangyian
force-pushed
the
api-ui-mocks
branch
from
f7a6699 to
e97ebfb
Compare
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: GitHub Actions Bot <actions@github.com>
…ted publishing (DataJunction#1678) * Set up release and publish flow * Skip datajunction-query release until OIDC publishing is setup
Co-authored-by: GitHub Actions Bot <actions@github.com>
…so that npm won't expect a token (DataJunction#1680)
Co-authored-by: GitHub Actions Bot <actions@github.com>
Co-authored-by: GitHub Actions Bot <actions@github.com>
Co-authored-by: GitHub Actions Bot <actions@github.com>
Co-authored-by: GitHub Actions Bot <actions@github.com>
* Fix npm release by upgrading node * Fix package.json url to point to the correct repository * Fix release workflow to fetch previous version tag and generate release notes manually from git log
Co-authored-by: GitHub Actions Bot <actions@github.com>
shangyian
force-pushed
the
api-ui-mocks
branch
from
61db864 to
e510276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets up GraphQL code gen and creates a fully-typed GraphQL service layer for the DJ UI. All existing GraphQL methods in
DJService.jsnow delegate to the new typedDJGraphQLService.ts. This provides type safety without changing any existing components.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan