Skip to content

Add GraphQL OpenTelemetry integration#1395

Draft
shangyian wants to merge 3129 commits intoDataJunction:mainfrom
shangyian:add-telemetry
Draft

Add GraphQL OpenTelemetry integration#1395
shangyian wants to merge 3129 commits intoDataJunction:mainfrom
shangyian:add-telemetry

Conversation

@shangyian
Copy link
Copy Markdown
Collaborator

Summary

Adds GraphQL OpenTelemetry integration for tracing. See https://strawberry.rocks/docs/extensions/opentelemetry

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

GQL common dimensions query + dim attr output shape
Only generate preaggregated measures SQL where possible
shangyian and others added 3 commits May 27, 2025 18:50
…tion#1388)

* Fix the derived expression of count distinct metrics to use the count distinct argument

* Add separate treatment of measures for distinct quantifier aggregations

* Add support to complex expressions inside distinct-agg metrics

* Refactor names and add tests for resolving metric components

* Cleanup

* More naming cleanup

* Add graphql naming refactor

* Update comments and update GraphQL schema
* Add pagination to /cubes endpoint

* don't pull inactive nodes for /cubes/... endpoints
* Add endpoint to list available dialects

* Add support for GraphQL querying of dialects
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 1, 2025

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit c2113a8
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/6856c80bab38f40008f1aa88

shangyian and others added 24 commits June 3, 2025 00:16
Co-authored-by: GitHub Actions Bot <>
* Fix an issue where renaming dimensions for measures SQL creates should include both columns

* Fix tests

* Refactor to make it cleaner
…1396)

* Add option to delete materializations by node version.

* Lint and commments addressed.

* Comment addressed plus added node_revision_id to Materialization output.
* Replaces use of Depends(get_session) in get_context() with session middleware, since the former doesn't support teardown in Strawberry.

* Add test for db session middleware

* Fix tests
…ataJunction#1402)

* When a node is deactivated, its materializations should be as well

* Fix tests
Co-authored-by: GitHub Actions Bot <>
* Add filtering on columns for node revisions in GQL

* Add tests for resolvers
* Add docker compose with superset

* Remove comments

* add password init

* Add secret key

* docker compose file that works with superset

* Fix

* Fix names

* Fix

---------

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: GitHub Actions Bot <>
Fix the ignore files for unit test workflow.
* Fix test action.

* Add UI code filter.
* Skip deactivated nodes in namespace export.

* Adjust unit test.
* Add support for reader clusters

* Add ability to switch between reader and writer cluster across REST and GraphQL calls

* Fix tests

* Add test for reader/writer session

* Add example .env

* Fix

* Fix tests

* Set database connection max overflow to 100

* Clean up

* Fix graphql tests

* Fix

* Fix

* Fix
Co-authored-by: GitHub Actions Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants