Skip to content

fix(nodejs): upgrade Bun to 1.4.0 - #7615

Draft
bm1549 wants to merge 1 commit into
mainfrom
brian.marks/upgrade-bun-streaming-fix
Draft

fix(nodejs): upgrade Bun to 1.4.0#7615
bm1549 wants to merge 1 commit into
mainfrom
brian.marks/upgrade-bun-streaming-fix

Conversation

@bm1549

@bm1549 bm1549 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Motivation

Bun 1.3.13 can reject a valid streamed tarball when the first HTTP body chunk is too small. That can break dependency installation while building the Next.js weblog. Bun 1.4.0 includes oven-sh/bun#34861, which fixes the stream handling.

Changes

  • Upgrade every Node.js Bun image pin from 1.3.13 to 1.4.0.
  • Move the affected prebuilt base images and their consumers from base-v3 to base-v4.
  • Add the five base-v4 images to mirror_images.yaml.
  • Add TEST_THE_TEST coverage that rejects floating, variable, shortened, or pre-1.4.0 Bun references.
  • Preserve the generated mirror_images.yaml header when the pinned mirror tool updates the manifest.

Tested with:

  • ./run.sh TEST_THE_TEST tests/test_the_test/test_nodejs_bun_version.py tests/test_the_test/test_update_mirror_images.py (12 passed)
  • ./build.sh nodejs -w nextjs
  • Next.js production build using Bun 1.4.0
  • mypy, Ruff, yamlfmt, yamllint, parser checks, and AI Guard

Before merge, R&P needs to publish the five base-v4 images and regenerate mirror_images.lock.yaml from their public digests.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@bm1549 bm1549 added build-nodejs-base-images ai-generated The pull request includes a significant amount of AI-generated code labels Aug 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/test_the_test/test_nodejs_bun_version.py                          @DataDog/system-tests-core
mirror_images.yaml                                                      @DataDog/system-tests-core
tests/test_the_test/test_update_mirror_images.py                        @DataDog/system-tests-core
utils/build/docker/nodejs/anthropic-js.Dockerfile                       @DataDog/system-tests-reviewers
utils/build/docker/nodejs/docker-bake.hcl                               @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express4-typescript.Dockerfile                @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express4-typescript.base.Dockerfile           @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express4.Dockerfile                           @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express4.base.Dockerfile                      @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express5.Dockerfile                           @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express5.base.Dockerfile                      @DataDog/system-tests-reviewers
utils/build/docker/nodejs/fastify.Dockerfile                            @DataDog/system-tests-reviewers
utils/build/docker/nodejs/fastify.base.Dockerfile                       @DataDog/system-tests-reviewers
utils/build/docker/nodejs/google_genai-js.Dockerfile                    @DataDog/system-tests-reviewers
utils/build/docker/nodejs/nextjs.Dockerfile                             @DataDog/system-tests-reviewers
utils/build/docker/nodejs/nextjs.base.Dockerfile                        @DataDog/system-tests-reviewers
utils/build/docker/nodejs/openai-js.Dockerfile                          @DataDog/system-tests-reviewers
utils/build/docker/nodejs/parametric/Dockerfile                         @DataDog/system-tests-reviewers
utils/build/docker/nodejs/uds-express4.Dockerfile                       @DataDog/system-tests-reviewers
utils/scripts/update_mirror_images.py                                   @DataDog/system-tests-core

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 29, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

Testing the test | all-jobs-are-green

View more details · View in GitHub Actions

Job did not run: blocked by a failed job in an earlier pipeline stage.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bbfbc09 | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated The pull request includes a significant amount of AI-generated code build-nodejs-base-images

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant