Skip to content

fix(dotnet): declare FFE capability from 3.53 - #7612

Draft
pavlokhrebto wants to merge 1 commit into
mainfrom
pavlo.khrebto/dotnet-3.53-ffe-capability
Draft

fix(dotnet): declare FFE capability from 3.53#7612
pavlokhrebto wants to merge 1 commit into
mainfrom
pavlo.khrebto/dotnet-3.53-ffe-capability

Conversation

@pavlokhrebto

@pavlokhrebto pavlokhrebto commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Motivation

dd-trace-dotnet 3.53.0 recognizes DD_FEATURE_FLAGS_CONFIGURATION_SOURCE=remote_config and reports FFE_FLAG_CONFIGURATION_RULES during the Remote Config capability completeness test. The capability registry does not declare that bit for dotnet, so released-version validation rejects the correctly reported capability as seen_but_not_expected and fails the dotnet parametric job.

Changes

Updates the version-aware dotnet capability registry so FFE_FLAG_CONFIGURATION_RULES is expected starting with dotnet 3.53.0. Earlier dotnet versions keep their existing expected capability set.

Decisions

The capability is declared at >=3.53.0 instead of in the dotnet base set. Earlier versions contain the registration code, but Feature Flags only started when the legacy DD_EXPERIMENTAL_FLAGGING_PROVIDER_ENABLED opt-in was set, which DEFAULT_ENVVARS does not set, so the capability was never observable. 3.53.0 enables Feature Flags by default, so the explicit remote_config source in DEFAULT_ENVVARS is honored, the tracer subscribes to FFE_FLAGS, and the capability becomes observable. dotnet advertises it only for the remote_config source, matching Node, which gates on DD_FEATURE_FLAGS_CONFIGURATION_SOURCE === 'remote_config' in proxy.js.

Verification

  • ./format.sh — no changes
  • ./run.sh TEST_THE_TEST tests/test_the_test/test_capabilities.py — passed
  • dd-trace-dotnet PR #9044, where test_default_capability_completeness currently fails with seen_but_not_expected_capabilities={<Capabilities.FFE_FLAG_CONFIGURATION_RULES: 46>}

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/capabilities.yml                                       @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 28, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

Testing the test | System Tests (dotnet, dev) / parametric / parametric (1) — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

1 failed test. Assertion Error: expected_but_not_seen_capabilities={<Capabilities.FFE_FLAG_CONFIGURATION_RULES: 46>}; Update capabilities.yml to fix this.

Testing the test | all-jobs-are-green

View more details · View in GitHub Actions

Job did not run: blocked by a failed job in an earlier pipeline stage.

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/main HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: pavlo.khrebto/dotnet-3.53-ffe-capability

Testing the test | System Tests (dotnet, dev) / parametric / parametric (1)
Commit: 476528611a4f9674fb8d032976e9d6e017dff56c
Error (code / test):
1 failed test. Assertion Error: expected_but_not_seen_capabilities={<Capabilities.FFE_FLAG_CONFIGURATION_RULES: 46>}; Update capabilities.yml to fix this.
CI job: https://github.com/DataDog/system-tests/actions/runs/33165186602/job/98829352629

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6433f9a | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant