fix(dotnet): declare FFE capability from 3.53 - #7612
Draft
pavlokhrebto wants to merge 1 commit into
Draft
Conversation
Contributor
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dd-trace-dotnet3.53.0 recognizesDD_FEATURE_FLAGS_CONFIGURATION_SOURCE=remote_configand reportsFFE_FLAG_CONFIGURATION_RULESduring the Remote Config capability completeness test. The capability registry does not declare that bit for dotnet, so released-version validation rejects the correctly reported capability asseen_but_not_expectedand fails the dotnet parametric job.Changes
Updates the version-aware dotnet capability registry so
FFE_FLAG_CONFIGURATION_RULESis expected starting with dotnet 3.53.0. Earlier dotnet versions keep their existing expected capability set.Decisions
The capability is declared at
>=3.53.0instead of in the dotnet base set. Earlier versions contain the registration code, but Feature Flags only started when the legacyDD_EXPERIMENTAL_FLAGGING_PROVIDER_ENABLEDopt-in was set, whichDEFAULT_ENVVARSdoes not set, so the capability was never observable. 3.53.0 enables Feature Flags by default, so the explicitremote_configsource inDEFAULT_ENVVARSis honored, the tracer subscribes toFFE_FLAGS, and the capability becomes observable. dotnet advertises it only for theremote_configsource, matching Node, which gates onDD_FEATURE_FLAGS_CONFIGURATION_SOURCE === 'remote_config'inproxy.js.Verification
./format.sh— no changes./run.sh TEST_THE_TEST tests/test_the_test/test_capabilities.py— passedtest_default_capability_completenesscurrently fails withseen_but_not_expected_capabilities={<Capabilities.FFE_FLAG_CONFIGURATION_RULES: 46>}Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present