test(golang): add Gorilla OTel semantics weblog - #7584
Open
marcotc wants to merge 1 commit into
Open
Conversation
Contributor
|
|
marcotc
force-pushed
the
marcotc/apmapi-2047-go-restful-gorilla
branch
from
August 25, 2026 23:36
b105aaf to
9441649
Compare
marcotc
changed the base branch from
main
to
marcotc/apmapi-2047-go-restful-v3
August 25, 2026 23:37
5 tasks
marcotc
marked this pull request as ready for review
August 25, 2026 23:43
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 9441649 | Docs | View more details | Give us feedback! |
cbeauchesne
approved these changes
Aug 26, 2026
link04
approved these changes
Aug 27, 2026
link04
left a comment
Contributor
There was a problem hiding this comment.
LGTM nothing I could find, not sure if anyone from Go can take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
APMAPI-2047 extends the OpenTelemetry HTTP semantics RFC system-test coverage to a real Gorilla mux server integration.
Changes
gorilla-muxGo weblog with framework-native route matching and tracednet/httpdownstream calls.Validation
The weblog builds and passes all forced semantic test classes against dd-trace-go commit
3f75582cb90f232ddcace4ebd2fc7a2296320851. Scenario-selection validation and relevantTEST_THE_TESTchecks also pass. The full stacked tree matches the previously validated combined change, except the shared test expectation now comes from #7573.Stack
Gotchas
The Go manifest remains unchanged because the eventual dd-trace-go release version is not known. The semantic classes therefore remain marked
missing_featureuntil that release version can be recorded; this PR stays draft meanwhile.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present