Skip to content

[APPSEC-69800] Stop expecting unused and sensitive _dd.appsec.usr tags - #7581

Open
florentinl wants to merge 1 commit into
mainfrom
dd/appsec-69800-remove-dd-appsec-usr-tags-202608251330
Open

[APPSEC-69800] Stop expecting unused and sensitive _dd.appsec.usr tags#7581
florentinl wants to merge 1 commit into
mainfrom
dd/appsec-69800-remove-dd-appsec-usr-tags-202608251330

Conversation

@florentinl

@florentinl florentinl commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Motivation

APPSEC-69800 removes system-tests expectations for sensitive user tags in the _dd.appsec namespace. The library follow-up work can remove _dd.appsec.usr.id and _dd.appsec.usr.login without these tests requiring those tags to stay present.

Changes

  • Removed _dd.appsec.usr.id assertions from automated user tracking and V3 login event tests.
  • Removed _dd.appsec.usr.login assertions from V3 login event tests.
  • Updated standalone automated user-event checks and smoke validation to rely on public appsec.events.users.*.usr.login tags instead of _dd.appsec.usr.login.

Testing

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

PR by Bits - View session in Datadog

Comment @DataDog to request changes

Co-authored-by: florentinl <101594032+florentinl@users.noreply.github.com>
@datadog-prod-us1-3

Copy link
Copy Markdown
Contributor

View session in Datadog

Bits Code status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

@datadog-official

Copy link
Copy Markdown

I can only run on private repositories.

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/appsec/smoke_tests/utils.py                                       @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_asm_standalone.py                                     @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_automated_login_events.py                             @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_automated_user_and_session_tracking.py                @DataDog/asm-libraries @DataDog/system-tests-core

@florentinl
florentinl marked this pull request as ready for review August 25, 2026 13:44
@florentinl
florentinl requested review from a team as code owners August 25, 2026 13:44
@florentinl florentinl changed the title [APPSEC-69800] APPSEC-69800 Stop expecting appsec usr tags [APPSEC-69800] Stop expecting unused and sensitive _dd.appsec.usr tags Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants