Auto-activate nodejs easy wins for apm-idm - #7576
Conversation
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: waiting for CI tests to complete... |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b7c1b7b97
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - weblog_declaration: | ||
| nextjs: missing_feature | ||
| tests/test_otel_http_semantics.py::Test_OtelSemantics_OTLP_TraceMetrics::test_trace_metric_agrees_with_client_success: | ||
| - declaration: missing_feature (successful client trace metrics still report OTel error status) |
There was a problem hiding this comment.
For Node.js 6.12+ on express4, this unconditional declaration still matches because manifest conditions accumulate; the following weblog_declaration cannot override it merely by omitting express4. Consequently this test remains skipped despite the attempted activation. The same unconditional-first pattern also prevents express4 activation for the server-success metric, peer-service, HTTP-500, and HTTP-endpoint tests; make the retained declarations weblog-scoped so express4 is actually carved out.
Useful? React with 👍 / 👎.
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
2b7c1b7 to
01e5a0b
Compare
new commit added, dismiss all previous approvals
01e5a0b to
08feae2
Compare
new commit added, dismiss all previous approvals
08feae2 to
e923fb5
Compare
new commit added, dismiss all previous approvals
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 49d51ad | Docs | View more details | Give us feedback! |
e923fb5 to
561b9f3
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
561b9f3 to
49d51ad
Compare
Automated activation of easy-win tests for
nodejsowned byapm-idmView nightly workflow run