Build metadata#7137
Draft
nccatoni wants to merge 7 commits into
Draft
Conversation
Introduce {name}.weblog.json companion files alongside Dockerfiles.
When require_build is false, the weblog is excluded from
build_end_to_end's matrix, which already skips the job when the
list is empty. Set all Node.js regular weblogs to require_build=false.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When require_build=False, artifact_name must use the pre-existing binaries_artifact instead of a unique per-run name, since build_end_to_end is skipped and never uploads that artifact. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
require_build controls parallel_weblogs (pre-build job). needs_local_build controls weblog_build_required in run_end_to_end. Non-Dockerfile weblogs (integration frameworks, go_proxies, otel_collector) set needs_local_build=False; Dockerfile-based weblogs default to True, so they still build locally even when require_build=False skips the pre-build job. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
require_build now consistently means 'needs Docker build' (True for all Dockerfile weblogs, False for non-Dockerfile). require_prebuild controls parallel_weblogs membership and _get_build_time. Metadata key renamed from require_build to require_prebuild accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
|
nccatoni
force-pushed
the
nccatoni/local-build
branch
2 times, most recently
from
05db838 to
56966f5
Compare
nccatoni
force-pushed
the
nccatoni/local-build
branch
from
56966f5 to
2976ce1
Compare
|
rochdev
force-pushed
the
rochdev/weblog-build-metadata
branch
from
8d7e3e7 to
2cc3e61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present