Skip to content

chore(crashtracking): check v2 telemetry payload structure#6348

Merged
gyuheon0h merged 4 commits intomainfrom
gyuheon0h/ct-v2-log
Feb 20, 2026
Merged

chore(crashtracking): check v2 telemetry payload structure#6348
gyuheon0h merged 4 commits intomainfrom
gyuheon0h/ct-v2-log

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Feb 19, 2026

Motivation

v2 telemetry logs are in the form payload:{logs:[]}. We should handle this case too. Libdatadog was updated in v27 with this PR: [fix(telemetry)!: fix logs payload format APMSP-2590](DataDog/libdatadog#1498) to send crash logs in this form.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@gyuheon0h gyuheon0h requested a review from a team as a code owner February 19, 2026 16:15
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGTM, but could you get a review from someone familiar with the feature ?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/interfaces/_test_agent.py                                         @DataDog/system-tests-core

@gyuheon0h
Copy link
Contributor Author

AGTM, but could you get a review from someone familiar with the feature ?

I own crashtracking, so I will go ahead with merging in a bit if you do not have any objections

Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@datadog-datadog-prod-us1

This comment has been minimized.

@gyuheon0h
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 19, 2026

View all feedbacks in Devflow UI.

2026-02-19 21:16:34 UTC ℹ️ Start processing command /merge


2026-02-19 21:16:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-19 21:18:30 UTC ⚠️ MergeQueue: This merge request was unqueued

gyuheon.oh@datadoghq.com unqueued this merge request

@gyuheon0h
Copy link
Contributor Author

/remove

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 19, 2026

View all feedbacks in Devflow UI.

2026-02-19 21:18:25 UTC ℹ️ Start processing command /remove


2026-02-19 21:18:28 UTC ℹ️ Devflow: /remove

@gyuheon0h
Copy link
Contributor Author

/merge -@ in 3 hours

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 20, 2026

View all feedbacks in Devflow UI.

2026-02-20 00:06:51 UTC ℹ️ Start processing command /merge -@ in 3 hours


2026-02-20 00:06:54 UTC ℹ️ MergeQueue: merge request scheduled for Fri, 20 Feb 2026 03:06:51 UTC

Pull Request scheduled to be added to the queue on Fri, 20 Feb 2026 03:06:51 UTC


2026-02-20 00:23:01 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@gyuheon0h gyuheon0h merged commit 1ca9d59 into main Feb 20, 2026
2611 of 2616 checks passed
@gyuheon0h gyuheon0h deleted the gyuheon0h/ct-v2-log branch February 20, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants