Skip to content

Fix darwin condition#6333

Merged
lloeki merged 2 commits intomainfrom
lloeki/fix-darwin-condition
Feb 18, 2026
Merged

Fix darwin condition#6333
lloeki merged 2 commits intomainfrom
lloeki/fix-darwin-condition

Conversation

@lloeki
Copy link
Member

@lloeki lloeki commented Feb 18, 2026

Motivation

This is not JSON: double quotes don't work, and only single quotes work.

FUP to #6313

Changes

Use single quotes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@lloeki lloeki requested a review from a team as a code owner February 18, 2026 08:16
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/nix.yml                                               @DataDog/system-tests-core

@lloeki lloeki enabled auto-merge (squash) February 18, 2026 09:36
@lloeki lloeki merged commit 331f772 into main Feb 18, 2026
420 checks passed
@lloeki lloeki deleted the lloeki/fix-darwin-condition branch February 18, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments