Auto-activate nodejs manifest tests

[dd-octo-sts]

Automated activation of easy-win tests for nodejs
View nightly workflow run

• If you approve this PR please also merge it.
• If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
• If you close the PR please also delete the branch

[github-actions]

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js

[datadog-official]

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 2 Tests failed

tests.test_telemetry.Test_DependencyEnable.test_app_dependency_loaded_not_sent_dependency_collection_disabled[express4] from system_tests_suite (Datadog) (Fix with Cursor)

ValueError: request_type app-dependencies-loaded should not be sent by this tracer

self = <tests.test_telemetry.Test_DependencyEnable object at 0x7f87e5514530>

    def test_app_dependency_loaded_not_sent_dependency_collection_disabled(self):
        """app-dependencies-loaded request should not be sent if DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED is false"""
    
        for data in interfaces.library.get_telemetry_data():
            if get_request_type(data) == "app-dependencies-loaded":
>               raise ValueError("request_type app-dependencies-loaded should not be sent by this tracer")
...

tests.test_telemetry.Test_DependencyEnable.test_app_dependency_loaded_not_sent_dependency_collection_disabled[uds-express4] from system_tests_suite (Datadog) (Fix with Cursor)

ValueError: request_type app-dependencies-loaded should not be sent by this tracer

self = <tests.test_telemetry.Test_DependencyEnable object at 0x7f42f8d104d0>

    def test_app_dependency_loaded_not_sent_dependency_collection_disabled(self):
        """app-dependencies-loaded request should not be sent if DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED is false"""
    
        for data in interfaces.library.get_telemetry_data():
            if get_request_type(data) == "app-dependencies-loaded":
>               raise ValueError("request_type app-dependencies-loaded should not be sent by this tracer")
...

ℹ️ Info

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bbe53bb | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

[watson]

Just personal preference, but I'm not a fan of the comments. I don't think they add anything useful and they are just noise. If we somehow got confused as to why a test was active, we'd just use git blame to see why.

[simon-id]

@nccatoni what the hell does this change mean ? 😆
am i wrong in understanding that this does nothing ? it's the same declaration twice ?

[nccatoni]

It's weblog on the first one and excluded_weblog on the second one so it activates the test for express5, express4-typescript, fastify, express4, uds-express4 starting version 5.86.0

[simon-id]

same thing here ???

[simon-id]

PR is outdated already, and it's doing weird stuff so we'll see next one