telemetry: address flakiness in app-started test#6311
Draft
Conversation
Contributor
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: e955276 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
8c978e2 to
e955276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
test_app_started_is_first_messagetest needed to be refactored to properly handle multiple runtime_ids when processes fork. Forked processes may not submit app-started/app-closed events and may only generate metrics or logs.Changes
Refactored
test_app_started_is_first_messageintests/test_telemetry.pyto:flatten_message_batches=Trueto simplify message handlingruntime_idand sort each group byseq_idto maintain correct orderruntime_idhasapp-startedas its first message (accounting for forked processes that may not send app-lifecycle events)Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present