Implementing IfThen Expression Type To and From Substrait text#52
Open
Implementing IfThen Expression Type To and From Substrait text#52
Conversation
gord02
commented
Feb 10, 2026
wackywendell
requested changes
Feb 11, 2026
Collaborator
wackywendell
left a comment
wackywendell
left a comment
There was a problem hiding this comment.
In general, good code change!
I have one moderate suggestion, see attached, and two significant ones:
- Let's update
GRAMMAR.mdto note the addition of this to the grammar. - Let's also add or extend a roundtrip test to include an
IfThenexample. In general, testing should not come in separate PRs, but should come in the same PR as the implementation.
gord02
force-pushed
the
gordon.hamilton/implement-ifThen
branch
from
5edd02d to
a3de7b5
Compare
Collaborator
wackywendell
left a comment
wackywendell
left a comment
There was a problem hiding this comment.
One very small change, then we're good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the ifThen Expression Type To and From Substrait text.
Type of Change
Testing