Support OAuth for logs saved-views create/delete | DAL-942 - #698
Merged
platinummonkey merged 2 commits intoAug 3, 2026
Merged
Conversation
Server now accepts ValidOAuthAccessToken for POST/DELETE on /api/v1/logs/views; remove them from OAUTH_EXCLUDED_ENDPOINTS and add saved_views_write to default_scopes().
srosenthal-dd
changed the title
srosenthal-dd
marked this pull request as ready for review
August 3, 2026 15:09
platinummonkey
previously approved these changes
Aug 3, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 455a4f8ee0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ed-views-scope # Conflicts: # src/auth/types.rs
platinummonkey
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/logs/viewsandDELETE /api/v1/logs/views/*fromOAUTH_EXCLUDED_ENDPOINTS, sosaved-views create/deletesend an OAuth bearer token when available instead of always falling back to API/app key.saved_views_writetodefault_scopes().Test plan