Skip to content

Fix serialization cache bypass in _serialize_included#14

Open
csabella wants to merge 1 commit intodevfrom
csabella/fix-serialization-cache
Open

Fix serialization cache bypass in _serialize_included#14
csabella wants to merge 1 commit intodevfrom
csabella/fix-serialization-cache

Conversation

@csabella
Copy link

@csabella csabella commented Feb 18, 2026

Summary

  • The merge conflict resolution in d68f0ce kept both sides of a conflict in _serialize_included(), causing every included resource to be serialized fresh even when a cached result exists
  • The cached result was computed but immediately overwritten by an unconditional schema.dump() call on the next line
  • Removes the duplicate lines so the cache is actually used
  • Bumps version to 0.24.1

Before (broken)

data = result                          # result from cache
item = data["data"]                    # extracts item from cache
result = self.schema.dump(value)       # DUMPS AGAIN unconditionally
item = result["data"]                  # OVERWRITES cached item

After (fixed)

item = result["data"]

🤖 Generated with Claude Code

@csabella csabella force-pushed the csabella/fix-serialization-cache branch from b47f9b5 to bd76cf8 Compare February 18, 2026 00:38
The merge conflict resolution in d68f0ce kept both sides of a conflict
in _serialize_included(), causing every included resource to be serialized
fresh even when a cached result exists. The cached result was computed but
immediately overwritten by an unconditional schema.dump() call on the next
line.

Remove the duplicate lines so the cache is actually used.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@csabella csabella force-pushed the csabella/fix-serialization-cache branch from bd76cf8 to 89932e2 Compare February 18, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments