Fix serialization cache bypass in _serialize_included#14
Open
Fix serialization cache bypass in _serialize_included#14
Conversation
b47f9b5 to
bd76cf8
Compare
The merge conflict resolution in d68f0ce kept both sides of a conflict in _serialize_included(), causing every included resource to be serialized fresh even when a cached result exists. The cached result was computed but immediately overwritten by an unconditional schema.dump() call on the next line. Remove the duplicate lines so the cache is actually used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bd76cf8 to
89932e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_serialize_included(), causing every included resource to be serialized fresh even when a cached result existsschema.dump()call on the next lineBefore (broken)
After (fixed)
🤖 Generated with Claude Code