Skip to content

fix(libdd-trace-obfuscate): obfuscate HELLO|MIGRATE|ACL#1587

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
Feb 18, 2026
Merged

fix(libdd-trace-obfuscate): obfuscate HELLO|MIGRATE|ACL#1587
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello

Conversation

@duncanista
Copy link
Contributor

@duncanista duncanista commented Feb 17, 2026

What does this PR do?

APM: On span tags, add obfuscation on HELLO, MIGRATE and ACL redis commands. Similar to AUTH, all arguments passed to these commands will be obfuscated and replaced with ?.

Motivation

These commands can contain sensitive information, and should be obfuscated.

Additional Notes

Mirror from DataDog/datadog-agent#46391 and DataDog/datadog-agent#46548

How to test the change?

Unit tests

@duncanista duncanista requested review from a team as code owners February 17, 2026 18:02
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 27 27 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-crashtracker 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 219 219 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the Redis command obfuscation logic in libdd-trace-obfuscation to treat HELLO and MIGRATE like AUTH, replacing all arguments with ? to prevent sensitive data from appearing in span tags.

Changes:

  • Add HELLO and MIGRATE to the “obfuscate all args” command list in the Redis obfuscator.
  • Add unit tests covering HELLO/MIGRATE with and without arguments (including common variants).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.11%. Comparing base (2078f6f) to head (175587d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
+ Coverage   71.09%   71.11%   +0.02%     
==========================================
  Files         423      423              
  Lines       61928    61933       +5     
==========================================
+ Hits        44030    44046      +16     
+ Misses      17898    17887      -11     
Components Coverage Δ
libdd-crashtracker 62.43% <ø> (-0.02%) ⬇️
libdd-crashtracker-ffi 15.80% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 86.94% <ø> (ø)
libdd-data-pipeline-ffi 74.39% <ø> (ø)
libdd-common 80.58% <ø> (ø)
libdd-common-ffi 73.75% <ø> (ø)
libdd-telemetry 62.52% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.71% <ø> (ø)
libdd-profiling 81.36% <ø> (-0.03%) ⬇️
libdd-profiling-ffi 63.66% <ø> (ø)
datadog-sidecar 32.78% <ø> (ø)
datdog-sidecar-ffi 9.50% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 94.21% <100.00%> (+0.02%) ⬆️
libdd-trace-protobuf 68.00% <ø> (ø)
libdd-trace-utils 89.09% <ø> (ø)
datadog-tracer-flare 88.95% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Benchmarks

Comparison

Benchmark execution time: 2026-02-18 17:45:29

Comparing candidate commit 175587d in PR branch jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello with baseline commit 2078f6f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 35.140µs 35.605µs ± 0.731µs 35.286µs ± 0.068µs 35.367µs 37.140µs 37.211µs 38.500µs 9.11% 1.765 1.504 2.05% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [35.504µs; 35.706µs] or [-0.284%; +0.284%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 187.790ns 190.494ns ± 2.013ns 190.337ns ± 1.596ns 191.633ns 194.343ns 195.232ns 195.956ns 2.95% 0.645 -0.406 1.05% 0.142ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.215ns; 190.773ns] or [-0.146%; +0.146%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.692ms 10.716ms ± 0.013ms 10.715ms ± 0.008ms 10.722ms 10.737ms 10.766ms 10.791ms 0.71% 1.568 5.509 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.714ms; 10.718ms] or [-0.017%; +0.017%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.895µs 161.700µs ± 0.272µs 161.649µs ± 0.141µs 161.834µs 162.133µs 162.495µs 163.244µs 0.99% 1.528 7.477 0.17% 0.019µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.663µs; 161.738µs] or [-0.023%; +0.023%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.223µs 3.196µs ± 1.457µs 3.018µs ± 0.024µs 3.041µs 3.400µs 13.922µs 15.463µs 412.36% 7.542 57.413 45.47% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.994µs; 3.398µs] or [-6.317%; +6.317%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.917µs 3.918µs 3.919µs 0.16% -1.643 10.862 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255153303.112op/s 255564528.275op/s ± 169151.763op/s 255559008.342op/s ± 99997.684op/s 255656858.098op/s 255799760.446op/s 255883889.051op/s 256755579.838op/s 0.47% 1.663 11.025 0.07% 11960.836op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 78.868µs 80.815µs ± 0.806µs 80.747µs ± 0.491µs 81.303µs 82.216µs 82.913µs 83.651µs 3.60% 0.425 0.564 1.00% 0.057µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11954427.409op/s 12375154.295op/s ± 122965.547op/s 12384284.965op/s ± 75135.533op/s 12449953.978op/s 12577786.679op/s 12643857.828op/s 12679356.658op/s 2.38% -0.355 0.464 0.99% 8694.977op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 71.812µs 72.457µs ± 0.454µs 72.381µs ± 0.317µs 72.717µs 73.249µs 73.761µs 74.394µs 2.78% 1.006 1.279 0.63% 0.032µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13441858.450op/s 13801748.099op/s ± 86015.057op/s 13815870.335op/s ± 60526.724op/s 13871549.898op/s 13908583.404op/s 13919552.728op/s 13925194.855op/s 0.79% -0.965 1.123 0.62% 6082.183op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.916µs 3.918µs 3.920µs 3.921µs 0.21% -1.313 9.298 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255015886.113op/s 255530063.311op/s ± 196907.859op/s 255538990.080op/s ± 134854.906op/s 255661467.408op/s 255784309.227op/s 255856101.502op/s 256873888.990op/s 0.52% 1.335 9.467 0.08% 13923.488op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 68.589µs 69.158µs ± 0.356µs 69.095µs ± 0.239µs 69.347µs 69.867µs 70.171µs 70.232µs 1.65% 0.783 0.198 0.51% 0.025µs 1 200
credit_card/is_card_number/378282246310005 throughput 14238439.860op/s 14460084.381op/s ± 74053.874op/s 14472897.365op/s ± 50113.842op/s 14521584.892op/s 14551595.235op/s 14573900.300op/s 14579506.422op/s 0.74% -0.759 0.144 0.51% 5236.400op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 45.531µs 45.738µs ± 0.083µs 45.735µs ± 0.058µs 45.797µs 45.882µs 45.934µs 45.952µs 0.48% 0.109 -0.334 0.18% 0.006µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21761713.018op/s 21863717.212op/s ± 39712.978op/s 21865241.918op/s ± 27918.313op/s 21890925.665op/s 21925527.234op/s 21946421.706op/s 21963126.418op/s 0.45% -0.100 -0.336 0.18% 2808.132op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.429µs 6.441µs ± 0.014µs 6.438µs ± 0.003µs 6.441µs 6.487µs 6.497µs 6.500µs 0.96% 3.213 9.716 0.21% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 153855582.152op/s 155258075.531op/s ± 330952.424op/s 155326877.094op/s ± 74212.904op/s 155402454.991op/s 155501010.636op/s 155529790.201op/s 155550434.140op/s 0.14% -3.204 9.673 0.21% 23401.870op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.915µs 3.918µs 3.919µs 3.920µs 0.16% -1.772 12.077 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255096897.898op/s 255516225.170op/s ± 191012.728op/s 255506356.920op/s ± 124349.653op/s 255656071.768op/s 255766100.934op/s 255815488.805op/s 256903631.789op/s 0.55% 1.797 12.291 0.07% 13506.640op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 61.153µs 62.827µs ± 0.618µs 62.814µs ± 0.388µs 63.189µs 63.771µs 64.261µs 65.848µs 4.83% 0.775 2.941 0.98% 0.044µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15186517.658op/s 15918210.374op/s ± 155461.451op/s 15920015.624op/s ± 97788.935op/s 16022760.545op/s 16146645.693op/s 16252256.971op/s 16352425.836op/s 2.72% -0.651 2.498 0.97% 10992.785op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.824µs 54.013µs ± 0.066µs 54.015µs ± 0.039µs 54.053µs 54.123µs 54.168µs 54.244µs 0.42% 0.056 0.409 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18435165.653op/s 18514143.099op/s ± 22482.463op/s 18513271.803op/s ± 13403.266op/s 18527344.095op/s 18551655.314op/s 18560713.826op/s 18578955.617op/s 0.35% -0.047 0.401 0.12% 1589.750op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.890µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.915µs 3.919µs 3.921µs 3.922µs 0.21% -1.635 13.069 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254964246.651op/s 255502729.181op/s ± 214621.318op/s 255503406.938op/s ± 104737.707op/s 255618826.343op/s 255775748.696op/s 255856209.549op/s 257079337.339op/s 0.62% 1.667 13.327 0.08% 15176.019op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 50.190µs 50.385µs ± 0.105µs 50.374µs ± 0.057µs 50.430µs 50.524µs 50.736µs 50.945µs 1.13% 1.859 7.165 0.21% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19628889.701op/s 19847419.455op/s ± 41251.487op/s 19851655.298op/s ± 22291.458op/s 19873834.611op/s 19902020.156op/s 19909012.777op/s 19924237.835op/s 0.37% -1.823 6.954 0.21% 2916.921op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 45.546µs 45.715µs ± 0.078µs 45.712µs ± 0.050µs 45.765µs 45.846µs 45.891µs 45.956µs 0.53% 0.205 -0.028 0.17% 0.006µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21759907.539op/s 21874841.200op/s ± 37227.403op/s 21875961.601op/s ± 24040.221op/s 21899672.601op/s 21933962.587op/s 21954092.821op/s 21955833.685op/s 0.37% -0.195 -0.037 0.17% 2632.375op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.428µs 6.437µs ± 0.004µs 6.437µs ± 0.003µs 6.440µs 6.444µs 6.446µs 6.447µs 0.15% 0.065 -0.792 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 155117221.306op/s 155350194.766op/s ± 103550.912op/s 155356337.123op/s ± 82628.993op/s 155431995.681op/s 155516295.864op/s 155544079.553op/s 155570396.255op/s 0.14% -0.063 -0.793 0.07% 7322.155op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255541085.468op/s; 255587971.083op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [80.703µs; 80.927µs] or [-0.138%; +0.138%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12358112.453op/s; 12392196.137op/s] or [-0.138%; +0.138%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.394µs; 72.520µs] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13789827.239op/s; 13813668.958op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255502773.775op/s; 255557352.846op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.108µs; 69.207µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/378282246310005 throughput [14449821.226op/s; 14470347.535op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.727µs; 45.750µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [21858213.376op/s; 21869221.049op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.439µs; 6.443µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/x371413321323331 throughput [155212208.708op/s; 155303942.354op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255489752.643op/s; 255542697.697op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [62.742µs; 62.913µs] or [-0.136%; +0.136%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15896664.912op/s; 15939755.835op/s] or [-0.135%; +0.135%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [54.004µs; 54.022µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18511027.245op/s; 18517258.952op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255472984.730op/s; 255532473.632op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.370µs; 50.399µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19841702.396op/s; 19853136.514op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.704µs; 45.726µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [21869681.840op/s; 21880000.560op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.436µs; 6.438µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155335843.605op/s; 155364545.926op/s] or [-0.009%; +0.009%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 241.930ns 252.698ns ± 14.155ns 245.920ns ± 2.694ns 252.602ns 278.005ns 301.368ns 303.351ns 23.35% 1.903 3.086 5.59% 1.001ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [250.736ns; 254.660ns] or [-0.776%; +0.776%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.296µs 2.363µs ± 0.018µs 2.363µs ± 0.006µs 2.370µs 2.390µs 2.395µs 2.395µs 1.37% -1.427 3.432 0.77% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.360µs; 2.365µs] or [-0.107%; +0.107%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.825ms 14.860ms ± 0.028ms 14.856ms ± 0.010ms 14.866ms 14.892ms 14.983ms 15.023ms 1.12% 3.160 12.694 0.19% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.856ms; 14.864ms] or [-0.026%; +0.026%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 737.472µs 739.577µs ± 0.748µs 739.573µs ± 0.455µs 740.026µs 740.898µs 741.299µs 742.620µs 0.41% 0.288 0.953 0.10% 0.053µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [739.473µs; 739.681µs] or [-0.014%; +0.014%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.051µs 89.491µs ± 0.162µs 89.503µs ± 0.093µs 89.588µs 89.694µs 89.830µs 90.339µs 0.93% 0.686 4.714 0.18% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.469µs; 89.513µs] or [-0.025%; +0.025%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 47.925ms 48.246ms ± 0.757ms 48.141ms ± 0.059ms 48.207ms 48.315ms 50.837ms 56.464ms 17.29% 8.634 81.461 1.56% 0.054ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [48.142ms; 48.351ms] or [-0.217%; +0.217%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.453µs 24.390µs ± 8.678µs 17.906µs ± 0.328µs 31.973µs 39.900µs 40.769µs 65.082µs 263.47% 1.042 0.972 35.49% 0.614µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.188µs; 25.593µs] or [-4.931%; +4.931%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.187ms 4.192ms ± 0.008ms 4.191ms ± 0.001ms 4.192ms 4.197ms 4.204ms 4.287ms 2.31% 10.467 127.231 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.191ms; 4.193ms] or [-0.025%; +0.025%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.455ms 9.816ms ± 0.094ms 9.838ms ± 0.029ms 9.866ms 9.922ms 9.986ms 10.056ms 2.21% -1.443 2.463 0.96% 0.007ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.802ms; 9.829ms] or [-0.133%; +0.133%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.866µs 186.432µs ± 0.478µs 186.301µs ± 0.158µs 186.469µs 187.564µs 188.093µs 188.318µs 1.08% 1.936 3.209 0.26% 0.034µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5310180.239op/s 5363927.338op/s ± 13672.512op/s 5367668.522op/s ± 4553.093op/s 5372030.937op/s 5376401.210op/s 5378307.660op/s 5380215.817op/s 0.23% -1.925 3.163 0.25% 966.793op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.277µs 17.571µs ± 0.103µs 17.583µs ± 0.068µs 17.642µs 17.723µs 17.771µs 17.783µs 1.14% -0.453 -0.003 0.58% 0.007µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 56234145.751op/s 56914057.863op/s ± 334627.598op/s 56873646.303op/s ± 218953.523op/s 57118268.221op/s 57563863.426op/s 57728672.949op/s 57880390.902op/s 1.77% 0.485 0.033 0.59% 23661.744op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 9.890µs 9.946µs ± 0.024µs 9.943µs ± 0.015µs 9.961µs 9.986µs 10.002µs 10.013µs 0.70% 0.219 -0.172 0.24% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 99871919.980op/s 100546360.779op/s ± 237945.537op/s 100573576.481op/s ± 153849.293op/s 100712521.873op/s 100912911.404op/s 101073293.450op/s 101114653.983op/s 0.54% -0.206 -0.177 0.24% 16825.290op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [186.366µs; 186.498µs] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5362032.460op/s; 5365822.217op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.557µs; 17.585µs] or [-0.081%; +0.081%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [56867681.697op/s; 56960434.030op/s] or [-0.081%; +0.081%] None None None
normalization/normalize_name/normalize_name/good execution_time [9.942µs; 9.949µs] or [-0.033%; +0.033%] None None None
normalization/normalize_name/normalize_name/good throughput [100513383.816op/s; 100579337.742op/s] or [-0.033%; +0.033%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.972µs 5.041µs ± 0.048µs 5.050µs ± 0.034µs 5.072µs 5.128µs 5.130µs 5.133µs 1.63% 0.272 -0.958 0.94% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.035µs; 5.048µs] or [-0.131%; +0.131%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.479µs 146.291µs ± 3.023µs 145.882µs ± 0.498µs 146.419µs 147.916µs 156.533µs 182.700µs 25.24% 9.513 106.262 2.06% 0.214µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [145.872µs; 146.710µs] or [-0.286%; +0.286%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 175587d 1771435722 jordan.gonzalez/libdd-trace-obfuscate/redis-migrate-hello
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 493.331µs 494.092µs ± 0.726µs 493.999µs ± 0.242µs 494.280µs 494.676µs 495.088µs 503.046µs 1.83% 9.454 113.889 0.15% 0.051µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1987890.215op/s 2023918.284op/s ± 2934.175op/s 2024293.775op/s ± 992.538op/s 2025035.571op/s 2026147.775op/s 2026964.942op/s 2027035.245op/s 0.14% -9.338 111.971 0.14% 207.477op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 375.999µs 376.916µs ± 0.415µs 376.894µs ± 0.265µs 377.121µs 377.697µs 377.895µs 377.979µs 0.29% 0.445 -0.134 0.11% 0.029µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2645646.887op/s 2653113.826op/s ± 2922.858op/s 2653262.385op/s ± 1865.306op/s 2655214.611op/s 2657430.962op/s 2658564.700op/s 2659584.309op/s 0.24% -0.440 -0.139 0.11% 206.677op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 167.641µs 167.962µs ± 0.134µs 167.957µs ± 0.071µs 168.025µs 168.154µs 168.294µs 168.818µs 0.51% 1.758 8.999 0.08% 0.009µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5923527.535op/s 5953747.971op/s ± 4753.456op/s 5953906.105op/s ± 2520.174op/s 5956556.891op/s 5960229.868op/s 5962975.081op/s 5965122.897op/s 0.19% -1.740 8.872 0.08% 336.120op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 38.688µs 38.805µs ± 0.047µs 38.805µs ± 0.029µs 38.835µs 38.878µs 38.896µs 38.963µs 0.41% -0.113 0.227 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 25665374.843op/s 25770153.511op/s ± 30948.528op/s 25770014.201op/s ± 19563.399op/s 25788754.660op/s 25825779.494op/s 25846760.338op/s 25848108.158op/s 0.30% 0.121 0.224 0.12% 2188.391op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.657µs 45.764µs ± 0.052µs 45.761µs ± 0.033µs 45.797µs 45.859µs 45.902µs 45.968µs 0.45% 0.609 0.722 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21754151.885op/s 21851269.306op/s ± 25018.383op/s 21852902.941op/s ± 15874.405op/s 21868182.359op/s 21890501.874op/s 21896618.565op/s 21902446.503op/s 0.23% -0.601 0.702 0.11% 1769.067op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [493.992µs; 494.193µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2023511.636op/s; 2024324.932op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [376.858µs; 376.974µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2652708.746op/s; 2653518.906op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [167.943µs; 167.980µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5953089.188op/s; 5954406.755op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [38.798µs; 38.811µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [25765864.343op/s; 25774442.680op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.757µs; 45.771µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21847801.998op/s; 21854736.613op/s] or [-0.016%; +0.016%] None None None

Baseline

Omitted due to size.

@duncanista
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 17, 2026

View all feedbacks in Devflow UI.

2026-02-17 18:27:57 UTC ℹ️ Start processing command /merge


2026-02-17 18:28:03 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-17 18:29:16 UTC ⚠️ MergeQueue: This merge request was unqueued

jordan.gonzalez@datadoghq.com unqueued this merge request

@duncanista
Copy link
Contributor Author

/remove

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 17, 2026

View all feedbacks in Devflow UI.

2026-02-17 18:29:08 UTC ℹ️ Start processing command /remove


2026-02-17 18:29:12 UTC ℹ️ Devflow: /remove

@dd-octo-sts
Copy link

dd-octo-sts bot commented Feb 17, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 91.47 MB 91.47 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.38 MB 8.38 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 106.19 MB 106.19 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.75 MB 10.75 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 24.97 MB 24.97 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 75.94 KB 75.94 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 166.37 MB 166.39 MB +0% (+16.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 837.47 MB 837.47 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.55 MB 9.55 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 75.94 KB 75.94 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.00 MB 23.00 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.35 MB 48.35 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.05 MB 21.05 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.12 KB 77.12 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 170.13 MB 170.14 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 823.52 MB 823.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.22 MB 7.22 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.12 KB 77.12 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 24.59 MB 24.59 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 44.09 MB 44.09 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 80.02 MB 80.02 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.85 MB 9.85 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.14 MB 100.14 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.42 MB 11.42 MB 0% (0 B) 👌

@duncanista duncanista changed the title fix(libdd-trace-obfuscate): obfuscate HELLO|MIGRATE fix(libdd-trace-obfuscate): obfuscate HELLO|MIGRATE|ACL Feb 17, 2026
Copy link

@litianningdatadog litianningdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanista
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 18, 2026

View all feedbacks in Devflow UI.

2026-02-18 17:28:47 UTC ℹ️ Start processing command /merge


2026-02-18 17:28:56 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-18 18:07:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 45m (p90).


2026-02-18 18:38:12 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments