fix(libdd-trace-obfuscate): obfuscate HELLO|MIGRATE|ACL#1587
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
There was a problem hiding this comment.
Pull request overview
Extends the Redis command obfuscation logic in libdd-trace-obfuscation to treat HELLO and MIGRATE like AUTH, replacing all arguments with ? to prevent sensitive data from appearing in span tags.
Changes:
- Add
HELLOandMIGRATEto the “obfuscate all args” command list in the Redis obfuscator. - Add unit tests covering
HELLO/MIGRATEwith and without arguments (including common variants).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
+ Coverage 71.09% 71.11% +0.02%
==========================================
Files 423 423
Lines 61928 61933 +5
==========================================
+ Hits 44030 44046 +16
+ Misses 17898 17887 -11
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-18 17:45:29 Comparing candidate commit 175587d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
jordan.gonzalez@datadoghq.com unqueued this merge request |
|
/remove |
|
View all feedbacks in Devflow UI.
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
HELLO|MIGRATEHELLO|MIGRATE|ACL
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
Motivation
Additional Notes
Mirror from DataDog/datadog-agent#46391 and DataDog/datadog-agent#46548
How to test the change?
Unit tests