ci: add auto-commit of rustfmt changes action to CI APMSP-2770#1548
ci: add auto-commit of rustfmt changes action to CI APMSP-2770#1548gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
BenchmarksComparisonBenchmark execution time: 2026-02-10 18:12:52 Comparing candidate commit 2ae590b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
9f98074 to
cf65565
Compare
493e5dd to
5020044
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
- Coverage 71.16% 71.14% -0.02%
==========================================
Files 414 414
Lines 65739 65739
==========================================
- Hits 46786 46773 -13
- Misses 18953 18966 +13
🚀 New features to boost your workflow:
|
5020044 to
8a8ed91
Compare
bc3d9ac to
a3db3f7
Compare
74d5e76 to
2ae590b
Compare
| runs-on: ubuntu-latest | ||
| if: >- | ||
| contains(github.event.pull_request.labels.*.name, 'commit-rustfmt-changes') && | ||
| !startsWith(github.head_ref, 'mq-working-branch') |
There was a problem hiding this comment.
One option could be to run it only after the PR has been marked as ready with
if: ${{ !github.event.pull_request.draft }}
to reduce the friction caused by the commits due to fmt?
There was a problem hiding this comment.
That seems a bit redundant since you have to opt-in to the action with a label?
|
BTW, the "Documentation Check Results" and "Cargo Deny Results" should be removed by the workflow when no crates are modified. I have made a note of it as an improvement. |
2ae590b to
ad34bd4
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: ad34bd4 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
| retries: '45' | ||
| polling_interval: '1' | ||
| checks_exclude: 'devflow/merge,dd-gitlab/default-pipeline' | ||
| checks_exclude: 'devflow/merge,dd-gitlab/default-pipeline,Rustfmt Auto / rustfmt' |
There was a problem hiding this comment.
It works, but the spaces make me uneasy 😄
There was a problem hiding this comment.
I agree, but I think that's what GH wants.
What does this PR do?
Introduces a new GH workflow that uses rustfmt-check and can automatically apply
rustfmtchanges via a commit on your PR.This is currently opt-in via the
commit-rustfmt-changeslabel.The existing validation workflow still exists and is required to pass.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.