fix(profiling-ffi): Windows extern statics need __declspec(dllimport)#1468
Draft
morrisonlevi wants to merge 13 commits intomainfrom
Draft
fix(profiling-ffi): Windows extern statics need __declspec(dllimport)#1468morrisonlevi wants to merge 13 commits intomainfrom
morrisonlevi wants to merge 13 commits intomainfrom
Conversation
BenchmarksComparisonBenchmark execution time: 2026-02-18 02:01:46 Comparing candidate commit 3613641 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics. scenario:single_flag_killswitch/rules-based
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 70.85% 70.81% -0.05%
==========================================
Files 424 424
Lines 61963 61990 +27
==========================================
- Hits 43903 43896 -7
- Misses 18060 18094 +34
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
If they don't have this, they crash when dereferencing the pointer.
0802540 to
d844b01
Compare
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On the FFI headers on windows, this attends to replace
"extern "with"extern __declspec(dllimport) ".Motivation
These static variables result in a crash if you use them when they don't have
__declspec(dllimport).Additional Notes
This went unfound because none of the examples run on Windows in CI. I am planning to look into running these as part of CI (this is in draft still).
How to test the change?
Build and note you don't get a crash anymore when using these static vars on Windows 😆