Skip to content

fix: prevent memory leak in otel schema_version decode branch #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbachorik wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix: prevent memory leak in otel schema_version decode branch #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ddprof-lib/src/main/cpp/otel_process_ctx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,10 +806,16 @@ static otel_process_ctx_result otel_process_ctx_encode_protobuf_payload(char **o

// Dispatch based on key
if (strcmp(key_buffer, "threadlocal.schema_version") == 0) {
otel_thread_ctx_config_data *setup = (otel_thread_ctx_config_data *) calloc(1, sizeof(otel_thread_ctx_config_data));
if (!setup) { free(value); return false; }
setup->schema_version = value;
data_out->thread_ctx_config = setup;
if (!data_out->thread_ctx_config) {
otel_thread_ctx_config_data *setup = (otel_thread_ctx_config_data *) calloc(1, sizeof(otel_thread_ctx_config_data));
if (!setup) { free(value); return false; }
data_out->thread_ctx_config = setup;
} else {
if (((otel_thread_ctx_config_data *)data_out->thread_ctx_config)->schema_version) {
free((void *)((otel_thread_ctx_config_data *)data_out->thread_ctx_config)->schema_version);
}
}
((otel_thread_ctx_config_data *)data_out->thread_ctx_config)->schema_version = value;
} else {
char *key = strdup(key_buffer);
if (!key || extra_attributes_index + 2 >= extra_attributes_capacity) {
Expand Down
Loading