Skip to content

Apply queue_regex or queue_patterns to statistics metrics (ibm_mq.stats.queue.*)#23933

Open
ddog-nasirthomas wants to merge 7 commits into
masterfrom
nasir.thomas/ibm-mq-stats-regex
Open

Apply queue_regex or queue_patterns to statistics metrics (ibm_mq.stats.queue.*)#23933
ddog-nasirthomas wants to merge 7 commits into
masterfrom
nasir.thomas/ibm-mq-stats-regex

Conversation

@ddog-nasirthomas
Copy link
Copy Markdown
Contributor

What does this PR do?

Previously customers would set either queue_regex or queue_patterns and it was only used for queue discovery used by ibm_mq.queue.* metrics; statistics metrics from SYSTEM.ADMIN.STATISTICS.QUEUE were only emitted for all queues and ignore the configured regex or pattern.

This change allows customers to filter the queues the stats metrics are applied to by setting the config filter_queue_statistics_metrics:true. By default it is set to False to avoid any issues with customers who may be already monitoring stats metrics that were not getting filtered by queue_regex or queue_patterns

Motivation

Customer FR. Without this config there is very high metric cardinality and noisy data

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@ddog-nasirthomas
Copy link
Copy Markdown
Contributor Author

@codex review

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented Jun 4, 2026

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

PR | test / check   View in Datadog   GitHub Actions

PR | test / test (linux, ubuntu-22.04, ibm_mq, IBM MQ on Linux (py3.13-9), py3.13-9) / IBM MQ on Linux (py3.13-9)-py3.13-9   View in Datadog   GitHub Actions

See error Could not resolve host: ddintegrations.blob.core.windows.net during download attempt.

PR | test / test (linux, ubuntu-22.04, ibm_mq, IBM MQ on Linux (py3.13-9-cluster), py3.13-9-cluster) / IBM MQ on Linux (py3.13-9-cluster)-py3.13-9-cluster   View in Datadog   GitHub Actions

See error Connection failed: Could not resolve host 'ddintegrations.blob.core.windows.net'.

View all 8 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9c22464 | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ddog-nasirthomas ddog-nasirthomas added the qa/required QA is required for this PR and will generate a QA card label Jun 5, 2026
@ddog-nasirthomas ddog-nasirthomas marked this pull request as ready for review June 5, 2026 14:41
@ddog-nasirthomas ddog-nasirthomas requested review from a team as code owners June 5, 2026 14:41
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 5, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants