Apply queue_regex or queue_patterns to statistics metrics (ibm_mq.stats.queue.*)#23933
Open
ddog-nasirthomas wants to merge 7 commits into
Open
Apply queue_regex or queue_patterns to statistics metrics (ibm_mq.stats.queue.*)#23933ddog-nasirthomas wants to merge 7 commits into
ddog-nasirthomas wants to merge 7 commits into
Conversation
Contributor
Author
|
@codex review |
|
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
hestonhoffman
approved these changes
Jun 5, 2026
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously customers would set either
queue_regexorqueue_patternsand it was only used for queue discovery used byibm_mq.queue.*metrics; statistics metrics fromSYSTEM.ADMIN.STATISTICS.QUEUEwere only emitted for all queues and ignore the configured regex or pattern.This change allows customers to filter the queues the stats metrics are applied to by setting the config
filter_queue_statistics_metrics:true. By default it is set to False to avoid any issues with customers who may be already monitoring stats metrics that were not getting filtered byqueue_regexorqueue_patternsMotivation
Customer FR. Without this config there is very high metric cardinality and noisy data
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged