gpu: redirect to official setup instructions#23924
Conversation
mbertrone
left a comment
There was a problem hiding this comment.
Review
Two gate-level things to confirm before merge:
Rebase risk: This PR branches from an older master (gpu/README.md at ~166 lines). Current master has a 336-line README with a full docker run block, mixed-environment Helm two-chart instructions, and expanded Operator/DAP guidance that landed in separate subsequent PRs. When this rebases, the deletion needs to cleanly remove the current expanded setup section, not the older shorter one. Please rebase onto latest master and re-verify the diff before merging.
Unverified redirect target: The entire PR depends on https://docs.datadoghq.com/gpu_monitoring/setup/ being live and covering at minimum the Host, Docker, Helm, and Operator/mixed-environment setup paths removed here. If that page is incomplete or not yet published, users are left with no setup guidance. Please confirm it's live and comprehensive before merging.
OliviaShoup
left a comment
There was a problem hiding this comment.
Nice de-duplication — replacing the long, drift-prone setup block with a redirect to the canonical setup docs is a good call, and the target page resolves. README structure stays valid and there are no orphaned link references after the deletion. Approving.
One quick must-fix (a missing period) and a couple of small suggestions inline — none blocking.
One thing worth confirming: the removed content included the requirements (NVIDIA driver ≥ 450.51, kernel ≥ 5.8, Linux-only). Those should now live on the setup docs page you're redirecting to — just worth a sanity-check that they're covered there so that info isn't lost.
Review from OliviaShoup is dismissed. Related teams and files:
- documentation
- gpu/README.md
Fixed, rebased on latest
All docs are completed in that live page. |
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
Removes the setup instructions from the check README, redirecting instead to the setup page.
Motivation
Avoid duplicate instructions that get out of sync.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged