Skip to content

Add new config integration and dashboard#23914

Open
asopkin wants to merge 9 commits into
masterfrom
asopkin/make-config-audit
Open

Add new config integration and dashboard#23914
asopkin wants to merge 9 commits into
masterfrom
asopkin/make-config-audit

Conversation

@asopkin
Copy link
Copy Markdown
Contributor

@asopkin asopkin commented Jun 2, 2026

What does this PR do?

Makes the new dashboard added here generic: #22861

And moves to a generic integration.

Motivation

We want to make the hostname configuration dashboard generic (not specific to OTEl)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@asopkin asopkin requested review from a team as code owners June 2, 2026 14:50
@asopkin asopkin added the qa/skip-qa Automatically skip this PR for the next QA label Jun 2, 2026
@asopkin asopkin added qa/required QA is required for this PR and will generate a QA card qa/skip-qa Automatically skip this PR for the next QA and removed qa/skip-qa Automatically skip this PR for the next QA team/documentation qa/required QA is required for this PR and will generate a QA card labels Jun 2, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc651985d0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apm_config_audit/assets/dashboards/apm_config_audit_overview.json Outdated
@datadog-datadog-prod-us1-2

This comment has been minimized.

rtrieu
rtrieu previously approved these changes Jun 2, 2026
Copy link
Copy Markdown
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor suggestions for descriptive link text and clarification

Comment thread apm_config_audit/assets/dashboards/apm_config_audit_overview.json Outdated
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed rtrieu’s stale review June 3, 2026 00:27

Review from rtrieu is dismissed. Related teams and files:

  • documentation
    • apm_config_audit/assets/dashboards/apm_config_audit_overview.json
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 3, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants