Skip to content

SNMP: comment-only change to cisco-catalyst profile (CI baseline, do not merge)#23766

Draft
ian28223 wants to merge 3 commits into
masterfrom
ian.bucad/snmp-ci-baseline-comment-only
Draft

SNMP: comment-only change to cisco-catalyst profile (CI baseline, do not merge)#23766
ian28223 wants to merge 3 commits into
masterfrom
ian.bucad/snmp-ci-baseline-comment-only

Conversation

@ian28223
Copy link
Copy Markdown
Contributor

@ian28223 ian28223 commented May 20, 2026

What does this PR do?

Adds comment-only lines to three profile YAML files in snmp/datadog_checks/snmp/data/default_profiles/:

  • cisco-catalyst.yaml
  • _cisco-catalyst.yaml
  • cisco-sb.yaml

No behavior change. No content change. Just one comment line in each file so the CI test selector schedules the same e2e tests that PR #23498 triggers.

Motivation

Diagnostic baseline for AGENT-15682 and PR #23498. PR #23498 saw failures in test_e2e_snmp_listener, test_e2e_core.py::*, test_e2e_core_metadata.py::test_e2e_core_metadata_cisco_catalyst, and all of test_e2e_core_profiles/. Many of those tests cover profiles entirely unrelated to the cisco-catalyst / cisco-sb changes in #23498, suggesting environmental flake.

The initial single-file version of this PR confirmed test_e2e_snmp_listener is environmental (failed identically on both PRs), but the test_e2e_core_profiles/ tests were skipped on baseline because the file scope didn't trigger their selection. This expanded baseline touches the same three files as #23498, so the same tests should be scheduled and we get a like-for-like comparison.

Not for merge. Close after CI signal is observed.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the `qa/skip-qa` label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the `backport/` label to the PR and it will automatically open a backport PR once this one is merged

Adds a single comment line to verify the e2e test failures seen on
PR #23498 are environmental rather than caused by any profile content
change.

No behavior change; not for merge.
@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 20, 2026

Code Coverage  Pipelines  Tests

Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Total coverage percentage gate may be blocking this PR.

Overall coverage for service snmp: 26.22% (threshold: 30.00%)

⚠️ Warnings

🚦 6 Pipeline jobs failed

PR | test / test (linux, ubuntu-22.04, snmp, SNMP (py3.13-false), py3.13-false) / SNMP (py3.13-false)-py3.13-false   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Max retries exceeded while trying to resolve 'ddintegrations.blob.core.windows.net'.

PR | test / test (linux, ubuntu-22.04, snmp, SNMP (py3.13-true), py3.13-true) / SNMP (py3.13-true)-py3.13-true   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Name resolution failed for 'ddintegrations.blob.core.windows.net'.

PR | test / test-minimum-base-package (linux, ubuntu-22.04, snmp, SNMP (py3.13-false), py3.13-false) / minimum-base-package-SNMP (py3.13-false)-py3.13-false   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Connection error: Failed to resolve 'ddintegrations.blob.core.windows.net'.

View all 6 failed jobs.

🧪 20 Tests failed in 1 job

PR | run   GitHub Actions

test_bulk_table from test_check.py   View in Datadog (Fix with Cursor)
HTTPSConnectionPool(host='ddintegrations.blob.core.windows.net', port=443): Max retries exceeded with url: /snmp/cisco-3850.snmprec (Caused by NameResolutionError("HTTPSConnection(host='ddintegrations.blob.core.windows.net', port=443): Failed to resolve 'ddintegrations.blob.core.windows.net' ([Errno -2] Name or service not known)"))
test_cast_metrics from test_check.py   View in Datadog (Fix with Cursor)
HTTPSConnectionPool(host='ddintegrations.blob.core.windows.net', port=443): Max retries exceeded with url: /snmp/cisco-3850.snmprec (Caused by NameResolutionError("HTTPSConnection(host='ddintegrations.blob.core.windows.net', port=443): Failed to resolve 'ddintegrations.blob.core.windows.net' ([Errno -2] Name or service not known)"))

View all 20 test failures

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 18.30% (-69.63%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ca6164d | Docs | Datadog PR Page | Give us feedback!

Adds the same one-line comment to _cisco-catalyst.yaml and cisco-sb.yaml
so the CI test selector picks the same e2e tests as PR #23498. Lets us
compare like-for-like on the e2e_core_profiles failures.

No behavior change; not for merge.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.06%. Comparing base (3bce4ec) to head (08ee6bf).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 2, 2026

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant