Skip to content

Add octo-sts trust policy for validation PR comments#23269

Merged
AAraKKe merged 1 commit intomasterfrom
aarakke/add-validate-sts-policy
Apr 10, 2026
Merged

Add octo-sts trust policy for validation PR comments#23269
AAraKKe merged 1 commit intomasterfrom
aarakke/add-validate-sts-policy

Conversation

@AAraKKe
Copy link
Copy Markdown
Contributor

@AAraKKe AAraKKe commented Apr 10, 2026

What does this PR do?

Adds an octo-sts trust policy (self.validate.pull-request.sts.yaml) that grants the validation workflow permission to post PR comments with validation results.

This policy is a prerequisite for #23249, which replaces the 25 sequential validation steps with a parallel ddev validate all command that posts structured failure reports as PR comments.

Motivation

The validation workflow needs pull_requests: write to post comments on PRs. The octo-sts action exchanges an OIDC token for a scoped GitHub token using this trust policy, which is more secure than using secrets.GITHUB_TOKEN with broad permissions.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe requested a review from a team as a code owner April 10, 2026 09:47
@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Apr 10, 2026
@AAraKKe AAraKKe added this pull request to the merge queue Apr 10, 2026
Merged via the queue into master with commit 4e58c48 Apr 10, 2026
38 of 41 checks passed
@AAraKKe AAraKKe deleted the aarakke/add-validate-sts-policy branch April 10, 2026 09:52
@dd-octo-sts dd-octo-sts bot added this to the 7.79.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants