Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 32fa550 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32fa5503f3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| datadog-singlestore==4.6.0 | ||
| datadog-slurm==2.4.0; sys_platform == 'linux2' | ||
| datadog-snmp==12.3.0 | ||
| datadog-snmp==12.3.1 |
There was a problem hiding this comment.
This commit bumps datadog-snmp to 12.3.1 in the release requirements, but the integration source metadata remains at 12.3.0 in snmp/datadog_checks/snmp/__about__.py. That leaves the repository in an internally inconsistent state (requirements/changelog say 12.3.1 while package metadata says 12.3.0), which can confuse release tooling and local package builds that derive the version from __about__.py.
Useful? React with 👍 / 👎.
| if buckets["fragments"] and version_updated: | ||
| if process_fragments(integration, buckets["fragments"]): |
There was a problem hiding this comment.
In main(), fragment deletion is currently gated on version_updated, so any release where master is already on a higher version (the version-conflict case this script is meant to handle) will skip process_fragments and leave consumed changelog.d files behind. Those stale fragments can then be re-consumed in a later release and duplicate release notes.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
request: can we add this as a release command to ddev so we can actually test it? I have a comment to port commits from one place to another for quite some time but have not had the chance to actually move it to ddev. If the intention is to have a workflow that relies on this it is not acceptable to keep adding these to places we cannot control their stability and goes against the CI improvements we discussed.
Better to also remove it form this PR so we can actually port changelogs and discuss this in a separate update.
2 participants
What does this PR do?
Released cisco_aci, http, mysql, tls and checks base from 7.78.x.