Update dependency resolution#23256
Update dependency resolution#23256dd-octo-sts[bot] wants to merge 1 commit into7.79.0-patch-librdkafkafrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ca1aa09f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "linux-x86_64": "sha256:2d047922e507788caf56f9c838dabb8c6e7c03e1ace42d37089594edba817587", | ||
| "windows-x86_64": "sha256:76f8227272bd89c301135e20965950d996b57fc214e6ea735b685111090ee617" | ||
| } | ||
| {} |
There was a problem hiding this comment.
Keep image digests populated for non-rebuild runs
Replacing .deps/image_digests.json with {} will break the next dependency-resolution run where builder_changed == 'false': in .github/workflows/resolve-build-deps.yaml the build step reads jq -r '."${{ matrix.job.image }}"' and passes that value to .builders/build.py --digest (lines 208-209), and with missing keys jq -r returns null, so build.py tries to docker pull ghcr.io/datadog/agent-int-builder@null instead of a valid sha256 digest. This causes the linux/windows build path to fail until valid digests are restored.
Useful? React with 👍 / 👎.
Motivation
Direct dependencies were updated in 0d9d831.
Additional Notes
This PR was automatically generated by the following workflow:
https://github.com/DataDog/integrations-core/actions/runs/24199416972