Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
bf0a12b to
95b838c
Compare
AAraKKe
requested changes
Apr 9, 2026
AAraKKe
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the ReAct callback system from a single
ReActCallbackProtocol (requiring all 4 methods) into aCallbackSetdecorator-based registry where observers register only the events they care about.Four new/changed source files:
react/types.py(new) —ReActResultmoved here to avoid a circular importreact/callbacks.py(new) — four per-event callable Protocols +CallbackSetreact/process.py(changed) — dropsReActCallback, usescallback_sets: list[CallbackSet], dispatch loops collapse to singlefire_*callsThis PR also changes the name of the file
client.pytoanthropic_client.py(as well as its test), for it to be more descriptive. In that file, Anthropic-specific logic will live isolated from the rest of the model-agnostic files.Motivation
The old
ReActCallbackProtocol forced every observer to implement all 4 lifecycle methods even when it only cared about one. The newCallbackSetAPI lets callers register only what they need using decorator syntax:Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged