Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09bcc22574
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 9790ba6 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
| COMPOSE_FILE_E2E, patterns=["Finished all tasks"], service="prefect-worker", attempts=120, wait=1 | ||
| ), | ||
| CheckDockerLogs(COMPOSE_FILE_E2E, patterns=["Retried"], service="prefect-worker", attempts=120, wait=1), | ||
| WaitFor(lambda: _check_task_runs_available(prefect_url), attempts=60, wait=2), |
There was a problem hiding this comment.
60 attempts with a timeout of 10 seconds for each seems a bit long
How often do we expect the startup to take close to 10 minutes?
There was a problem hiding this comment.
You’re right, it shouldn’t take that long. I’ve reduced the timeout to 1 second, since the Prefect server is already healthy when the call is made.
2 participants
What does this PR do?
Adds an extra readiness check to the Prefect E2E test environment so the test waits until task runs and task-run events are actually queryable from the Prefect API before executing metric assertions.
Motivation
The Prefect E2E test is flaky because flow execution logs can appear before Prefect has fully persisted task-run records and task-run events. That race causes task-run metrics to be missing even though the flows already finished.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged