Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gord02
force-pushed
the
gordon.hamilton/ci-coverage-single-toolchain
branch
from
September 15, 2026 14:46
5a620c4 to
8d09a71
Compare
eatthepear
reviewed
Sep 15, 2026
eatthepear
left a comment
There was a problem hiding this comment.
Review test (This is to test if i have permission to review)
eatthepear
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust 1.96 and nightly ship different LLVMs which have diverged, so nightly's tools can't read the files 1.96 wrote. This fix means that the toolchain that writes the profiles is the one that reads them.