build(deps): bump datafusion 54 -> 55 - #1
Merged
Merged
Conversation
gord02
force-pushed
the
gordon.hamilton/datafusion-version-update
branch
from
September 15, 2026 13:10
545e886 to
7c3fad6
Compare
gord02
force-pushed
the
gordon.hamilton/datafusion-version-update
branch
from
September 16, 2026 16:47
7c3fad6 to
4e7871f
Compare
rohatgiy
approved these changes
Sep 16, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Two critical unreachable-pattern findings fail the Clippy lint gate, and the planner documentation needs updating.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates DataFusion from 54 to 55 and adapts the OpenLineage integration to the new APIs.
Changes:
- Updates dependencies, lockfile, and MSRV to Rust 1.94.
- Migrates planner, execution-plan, table-reference, and
WriteOphandling. - Refreshes tests, examples, contributor documentation, and CI.
File summaries
| File | Summary |
|---|---|
crates/open-lineage/tests/lineage.rs |
Updates test execution plans and child replacement. |
crates/open-lineage/src/rule.rs |
Migrates planner APIs. Nit (1 vote): update the design documentation’s planner signature. |
crates/open-lineage/src/extract.rs |
Updates DataFusion types and WriteOp matching. Critical (3 votes): remove the unreachable pattern alternative. |
crates/open-lineage/src/exec.rs |
Implements the new execution-plan API. |
crates/open-lineage/src/column.rs |
Updates WriteOp matching. Critical (3 votes): remove the unreachable pattern alternatives. |
crates/open-lineage/examples/e2e_pipeline/journey.rs |
Updates the TableReference import. |
CONTRIBUTING.md |
Documents the new MSRV. |
Cargo.toml |
Updates dependencies and MSRV. |
Cargo.lock |
Resolves the DataFusion 55 dependency graph. |
.github/workflows/ci.yml |
Updates the MSRV CI toolchain and warning-denying Clippy configuration. |
Review details
Suppressed comments (1)
crates/open-lineage/src/rule.rs:468
- This DataFusion 55 API migration changes the planner parameter to
&dyn Session, butdocs/open-lineage-design.md:61-76still documents&SessionStateand shows the old call signature. Update that current design documentation so users do not copy an incompatibleQueryPlannerimplementation.
session: &dyn Session,
- Files reviewed: 9/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| // No column values are written. | ||
| WriteOp::Delete | WriteOp::Truncate => None, | ||
| WriteOp::Delete | WriteOp::Truncate | _ => None, |
| }); | ||
| } | ||
| WriteOp::Truncate => {} | ||
| WriteOp::Truncate | _ => {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping the version of datafusion in the crate used in dd-soruce which already uses the latest version of datafusion.