Conversation
…ion rules Update prerequisites and destination setup steps to cover Slack and Microsoft Teams destinations for notification rules, and align cross-references on the Automations doc and recommendations overview. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
Content changes look good — expanding notification support to Microsoft Teams is reflected consistently across the three files. Two suggestions on gaps that surface now that Teams is a supported destination.
Reviewed 7c0ec8c4d4fb7f133a86b76cbb20c28ccae39acc — workflow run
| 1. In the {{< ui >}}Destination{{< /ui >}} section, select a Slack workspace connection and channel. | ||
| 1. In the {{< ui >}}Destination{{< /ui >}} section, select {{< ui >}}Slack{{< /ui >}} or {{< ui >}}Microsoft Teams{{< /ui >}}, then select a workspace and channel (Slack) or a tenant, team, and channel (Microsoft Teams). | ||
| 1. Enter a name for the notification rule. | ||
| 1. (Optional) Mention specific Slack users in the notification message. |
There was a problem hiding this comment.
Suggestion: Now that Microsoft Teams is a supported destination, this line should clarify whether @-mentions are available for Teams users as well, or explicitly note that mentions are Slack-only. As written, a user setting up a Teams notification may wonder whether this step applies to them.
| 1. (Optional) Mention specific Slack users in the notification message. | |
| 1. (Optional) Mention specific Slack users in the notification message. (Mentions are not available for Microsoft Teams destinations.) |
There was a problem hiding this comment.
i would prefer not stating this, the line already says "Mention specific Slack users," so "Slack" is doing the scoping work, imo adding this is redundant restating of what's already implied
|
|
||
| - A Slack connection. See [Slack integration][3]. | ||
| - The **Cloud Cost Management - Cloud Cost Management Write** permission to create or edit a notification rule. | ||
| - A Slack workspace or Microsoft Teams tenant with the Datadog app installed. See [Slack integration][3] or [Microsoft Teams integration][5]. For a private Slack channel, add the Datadog Slack app to that channel before you select it as a destination. |
There was a problem hiding this comment.
Suggestion: You call out the private-channel setup for Slack but say nothing about Microsoft Teams. If Teams requires an equivalent step (for example, adding the Datadog app to a private channel or team), consider adding a parallel sentence so Teams users don't hit an unexplained failure. If no extra step is needed for Teams, no change required.
There was a problem hiding this comment.
Teams doesn't have the same public/private channel distinction as Slack in this integration
1 participant
What does this PR do? What is the motivation?
Update prerequisites and destination setup steps to cover Slack and Microsoft Teams destinations for notification rules, and align cross-references on the Automations doc and recommendations overview.
Merge readiness
For Datadog employees:
<name>/<description>convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR./reviewto run an automated check that catches common issues before a Documentation team member reviews your PR.AI assistance
Used Claude Code to draft and verify the doc updates.
Additional notes
🤖 Generated with Claude Code