Skip to content

Add Network Path filter examples and IP URLs#35863

Open
ken-schneider wants to merge 2 commits intomasterfrom
dd/bits/network-path-filters-and-ip-urls
Open

Add Network Path filter examples and IP URLs#35863
ken-schneider wants to merge 2 commits intomasterfrom
dd/bits/network-path-filters-and-ip-urls

Conversation

@ken-schneider
Copy link
Copy Markdown
Contributor

@ken-schneider ken-schneider commented Apr 8, 2026

What does this PR do? What is the motivation?

Updates Network Path documentation to address two gaps:

  1. Dynamic test filter visibility: The include/exclude filter configuration for Dynamic (Network Traffic) paths was documented in a standalone section but not shown in the per-platform YAML configuration examples (Linux, Windows, Helm). Users copying the YAML examples had no visibility into filter options. This PR adds commented-out filter configuration with both include and exclude examples directly in each dynamic test tab's YAML block, referencing the existing filter syntax section.

  2. Source public IP allowlist: The datadog-traceroute library (v7.75+) performs a source public IP check by contacting external services over HTTPS. Users with restrictive firewall rules had no documentation on which URLs to allowlist. This PR adds a new "Source public IP resolution" section to the Network Path setup page listing all five IP check service URLs, clarifying this is optional and Network Path functions without it. Also adds a note to the Agent Network Traffic page.

Changes:

  • content/en/network_monitoring/network_path/setup.md: Added commented-out filters config with both include and exclude examples in the Linux, Windows, and Helm dynamic test YAML examples. Added a new "Source public IP resolution" subsection with a v7.75+ info banner, documenting the five external URLs (icanhazip.com, ipinfo.io/ip, checkip.amazonaws.com, api.ipify.org, whatismyip.akamai.com) and clarifying this feature is optional.
  • content/en/agent/configuration/network.md: Added a note under the Network Path destination entry listing the public IP check domains, noting this is optional and available in Agent v7.75+, and linking to the setup page for details.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

AI assistance

Used Bits AI to investigate the datadog-traceroute Go module source code (v1.0.14) to extract the exact public IP check URLs from publicip/fetcher.go, and to draft the documentation changes.

Additional notes

The public IP check URLs were sourced from the ipCheckers variable in github.com/DataDog/datadog-traceroute/publicip/fetcher.go (v1.0.14). The filter config examples mirror the existing filter syntax section already present in the setup page.


PR by Bits - View session in Datadog

Comment @DataDog to request changes

Co-authored-by: ken-schneider <103530259+ken-schneider@users.noreply.github.com>
@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 bot commented Apr 8, 2026

View session in Datadog

Bits Dev status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

I can only run on private repositories.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Co-authored-by: ken-schneider <103530259+ken-schneider@users.noreply.github.com>
@ken-schneider ken-schneider marked this pull request as ready for review April 9, 2026 19:52
@ken-schneider ken-schneider requested a review from a team as a code owner April 9, 2026 19:52
@git-thuerk-done git-thuerk-done self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ken-schneider this looks good I just had some feedback on the filter syntax links in the code blocks, let me know when this is ready for re-review!

## @param filters - list - optional
## Include or exclude specific domains or IP ranges from dynamic monitoring.
## Filters are applied sequentially, with later filters taking precedence.
## See the [filter syntax](#filter-syntax) section for details and examples.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## See the [filter syntax](#filter-syntax) section for details and examples.
## See the [filter syntax][1] section for details and examples.

This isn't linking out since it's in a code block and it's in a tab so I think you'd have to add the full URL within the tab, like:
[1]: /network-path-filters-and-ip-urls/network_monitoring/network_path/setup/?tab=linux#filter-syntax

## @param filters - list - optional
## Include or exclude specific domains or IP ranges from dynamic monitoring.
## Filters are applied sequentially, with later filters taking precedence.
## See the [filter syntax](#filter-syntax) section for details and examples.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## See the [filter syntax](#filter-syntax) section for details and examples.
## See the [filter syntax](#filter-syntax) section for details and examples.

same issue with this one

## @param filters - list - optional
## Include or exclude specific domains or IP ranges from dynamic monitoring.
## Filters are applied sequentially, with later filters taking precedence.
## See the [filter syntax](#filter-syntax) section for details and examples.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## See the [filter syntax](#filter-syntax) section for details and examples.
## See the [filter syntax](#filter-syntax) section for details and examples.

and this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants